Change width of rows in material design omnibox dropdown

chrome/browser/ui/views/omnibox/omnibox_result_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_RESULT_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_RESULT_VIEW_H_
 
 #include <vector>
 
 #include "base/gtest_prod_util.h"
@@ skipping 154 matching lines @@
                         const base::string16& text,
                         int text_type);
 
   // AppendAnswerText will break up the |text| into bold and non-bold pieces
   // and pass each to this helper with the correct |is_bold| value.
   void AppendAnswerTextHelper(gfx::RenderText* destination,
                               const base::string16& text,
                               int text_type,
                               bool is_bold);
 
+  // Returns the |left_margin_| and |right_margin_| members of
+  // OmniboxPopupContentsView if browser material design is enabled, and
+  // returns 0 otherwise. Used when laying out elements inside this view
+  // to ensure they are rendered within the region directly below the
+  // location bar.

[Peter Kasting, 2015/08/18 19:55:37]

Nit: How about:

Returns the necessary margin, if any, at the start and end of the view.  This
allows us to keep the icon and text in the view aligned with the location bar
constants.

(This avoids going into implementation details in an API comment.)

[tdanderson, 2015/08/19 17:22:35]

Done.

+  int LeftOffset() const;
+  int RightOffset() const;

[Peter Kasting, 2015/08/18 19:55:37]

I'd use "Margin" instead of "Offset" here, as a margin is a width and an offset
is a position.  These values are widths, not positions.

I'd also try to avoid "left" and "right" and prefer "Start" and "End" if
possible, though perhaps that change only makes sense when you fix this for RTL?

[tdanderson, 2015/08/19 17:22:35]

Done.
I was planning on addressing that if needed when looking at RTL. I picked "left"
and "right" to be consistent with the naming of |left_margin_| and
|right_margin_|.

+
   static int default_icon_size_;
 
   // This row's model and model index.
   OmniboxPopupContentsView* model_;
   size_t model_index_;
 
   LocationBarView* location_bar_view_;
 
   const gfx::FontList font_list_;
   int font_height_;
@@ skipping 22 matching lines @@
   mutable scoped_ptr<gfx::RenderText> separator_rendertext_;
   mutable scoped_ptr<gfx::RenderText> keyword_contents_rendertext_;
   mutable scoped_ptr<gfx::RenderText> keyword_description_rendertext_;
 
   mutable int separator_width_;
 
   DISALLOW_COPY_AND_ASSIGN(OmniboxResultView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_RESULT_VIEW_H_