Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1300823002: Introduce PositionAlgorithm<Strategy>::editingPositionOf() (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1, sof, eae+blinkwatch, leviw+renderwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-rendering, jchaffraix+rendering, rwlbuis, yoichio
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce PositionAlgorithm<Strategy>::editingPositionOf() This patch introduces |PositionAlgorithm<Strategy>::editingPositionOf()| as replacement of |createLegacyEditingPosition()| since Blink doesn't use legacy editing position since r200096, to remove a wrapper function for improving code health. BUG=513114 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200721

Patch Set 1 : 2015-08-18T17:38:11 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -41 lines) Patch
M Source/core/dom/RangeBoundaryPoint.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/Position.h View 2 chunks +1 line, -6 lines 0 comments Download
M Source/core/editing/Position.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/PositionIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/RenderedPosition.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/commands/DeleteSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/iterators/BackwardsCharacterIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/iterators/CharacterIterator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/editing/iterators/TextIterator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/spellcheck/SpellChecker.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutBlock.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-18 09:04:16 UTC) #2
tkent
lgtm
5 years, 4 months ago (2015-08-18 09:47:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300823002/1
5 years, 4 months ago (2015-08-18 09:47:35 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 10:58:18 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200721

Powered by Google App Engine
This is Rietveld 408576698