Source/core/editing/iterators/CharacterIterator.cpp - Issue 1300823002: Introduce PositionAlgorithm<Strategy>::editingPositionOf()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/iterators/CharacterIterator.cpp

Issue 1300823002: Introduce PositionAlgorithm<Strategy>::editingPositionOf() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-08-18T17:38:11 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/editing/iterators/BackwardsCharacterIterator.cpp ('k') | Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/iterators/CharacterIterator.cpp

diff --git a/Source/core/editing/iterators/CharacterIterator.cpp b/Source/core/editing/iterators/CharacterIterator.cpp

index 606f3180cf6ca2b187f4ed4788d0f001a9895be7..ec877a1ea0497e86622ca2dab58a201abc9953b1 100644

--- a/Source/core/editing/iterators/CharacterIterator.cpp

+++ b/Source/core/editing/iterators/CharacterIterator.cpp

@@ -107,7 +107,7 @@ PositionAlgorithm<Strategy> CharacterIteratorAlgorithm<Strategy>::startPosition(

if (m_textIterator.length() > 1) {

Node* n = m_textIterator.currentContainer();

int offset = m_textIterator.startOffsetInCurrentContainer() + m_runOffset;

- return PositionAlgorithm<Strategy>::createLegacyEditingPosition(n, offset);

+ return PositionAlgorithm<Strategy>::editingPositionOf(n, offset);

}

ASSERT(!m_runOffset);

}

@@ -121,7 +121,7 @@ PositionAlgorithm<Strategy> CharacterIteratorAlgorithm<Strategy>::endPosition()

if (m_textIterator.length() > 1) {

Node* n = m_textIterator.currentContainer();

int offset = m_textIterator.startOffsetInCurrentContainer() + m_runOffset;

- return PositionAlgorithm<Strategy>::createLegacyEditingPosition(n, offset + 1);

+ return PositionAlgorithm<Strategy>::editingPositionOf(n, offset + 1);

}

ASSERT(!m_runOffset);

}