Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Issue 1300803003: Drop ui::TouchEvent shims for radius_{x,y} and force (Closed)

Created:
5 years, 4 months ago by robert.bradford
Modified:
5 years, 3 months ago
Reviewers:
sadrul, oshima, sky
CC:
chromium-reviews, ozone-reviews_chromium.org, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jdduke+watch_chromium.org, tdresser+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop ui::TouchEvent shims for radius_{x,y} and force The users of these shims have been replaced with direct access to the underlying PointerDetails class. This change also makes the TouchEvent/MouseEvent::pointer_event() accessor const so it can be used on variables declared const. BUG=516706 TEST=Run through all the trybots. Committed: https://crrev.com/27a8f5c7873d4e990cd1b87f00c0888427b370d3 Cr-Commit-Position: refs/heads/master@{#347380}

Patch Set 1 : #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -36 lines) Patch
M ash/display/root_window_transformers_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/window_tree_host_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/touch/touch_hud_debug.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M ash/touch/touch_uma.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M mojo/converters/input_events/input_events_type_converters.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/events/event.h View 1 3 chunks +2 lines, -7 lines 0 comments Download
M ui/events/event_unittest.cc View 1 2 chunks +4 lines, -8 lines 0 comments Download
M ui/events/gestures/motion_event_aura.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/events/ozone/events_ozone.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/ozone/platform/egltest/ozone_platform_egltest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300803003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300803003/20001
5 years, 4 months ago (2015-08-20 14:49:48 UTC) #3
robert.bradford
Hi folks, please take a look at this change which is a follow-up to my ...
5 years, 4 months ago (2015-08-20 16:05:21 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-20 19:55:30 UTC) #7
oshima
I'll wait for sadul's approval for changes in ui/events.
5 years, 4 months ago (2015-08-21 23:42:30 UTC) #8
sadrul
lgtm
5 years, 4 months ago (2015-08-21 23:45:01 UTC) #9
robert.bradford
Ping oshima@ and sky@ could you review as owners of ash/ and mojo/ ?
5 years, 3 months ago (2015-09-03 15:55:47 UTC) #10
sky
LGTM
5 years, 3 months ago (2015-09-03 18:00:26 UTC) #11
oshima
lgtm
5 years, 3 months ago (2015-09-04 04:52:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300803003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300803003/40001
5 years, 3 months ago (2015-09-04 10:18:32 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 3 months ago (2015-09-04 11:17:55 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 11:18:29 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/27a8f5c7873d4e990cd1b87f00c0888427b370d3
Cr-Commit-Position: refs/heads/master@{#347380}

Powered by Google App Engine
This is Rietveld 408576698