content: Populate WebPointerProperties with stylus details from ui::MouseEvent

content: Populate WebPointerProperties with stylus details from ui::MouseEvent

ui::MouseEvent now holds values needed for implementing stylus support with
Pointer Events. This change populates the WebPointerProperties values with the
details from the MouseEvent's PointerDetails.

TEST=content_tests:TestMakeWebMouse[Wheel]Event
BUG=516706
Committed: https://crrev.com/f0cf27e36a998f506342022738902751a19df1cc
Cr-Commit-Position: refs/heads/master@{#348375}

[robert.bradford, 2015-08-26 13:06:20]

Patchset #1 (id:1) has been deleted

[robert.bradford, 2015-08-26 13:10:15]

robert.bradford@intel.com changed reviewers:
+ sadrul@chromium.org

[robert.bradford, 2015-08-26 13:10:16]

Hi Sadrul, please take a look at this patch as part of the ChromeOS stylus
Pointer Events enabling.

[sadrul, 2015-08-26 19:05:30]

https://codereview.chromium.org/1266643002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/web_input_event_aura.cc (right):

https://codereview.chromium.org/1266643002/diff/20001/content/browser/rendere...
content/browser/renderer_host/web_input_event_aura.cc:62: default:
Remove default case.

https://codereview.chromium.org/1266643002/diff/20001/content/browser/rendere...
content/browser/renderer_host/web_input_event_aura.cc:399: webkit_event.tiltX =
roundf(event.pointer_details().tilt_x());
Why roundf()?

What is the type of tiltX? (is there a blink CL that still hasn't landed?)

[robert.bradford, 2015-08-27 14:54:51]

Hi Sadrul, thanks for the review. Please see my comments below.

https://codereview.chromium.org/1266643002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/web_input_event_aura.cc (right):

https://codereview.chromium.org/1266643002/diff/20001/content/browser/rendere...
content/browser/renderer_host/web_input_event_aura.cc:62: default:
On 2015/08/26 19:05:30, sadrul wrote:
> Remove default case.

Done.

https://codereview.chromium.org/1266643002/diff/20001/content/browser/rendere...
content/browser/renderer_host/web_input_event_aura.cc:399: webkit_event.tiltX =
roundf(event.pointer_details().tilt_x());
On 2015/08/26 19:05:30, sadrul wrote:
> Why roundf()?
> 
> What is the type of tiltX? (is there a blink CL that still hasn't landed?)

The class is here
(https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...)
which is one of the superclasses of WebMouseEvent. The type of tiltX is int
(which matches the spec, where I think it is a bit odd that it uses just whole
degrees); I think rounding away is probably a better solution than truncating.

[sadrul, 2015-08-27 19:54:07]

Can you add a test in web_input_event_aura_unittest.cc to guard against
regressions from possible refactor etc.?

[robert.bradford, 2015-09-09 14:37:57]

The CQ bit was checked by robert.bradford@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-09 14:38:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1266643002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1266643002/60001

[robert.bradford, 2015-09-09 14:40:18]

On 2015/08/27 19:54:07, sadrul wrote:
> Can you add a test in web_input_event_aura_unittest.cc to guard against
> regressions from possible refactor etc.?

Hi Sadrul, apologies that this took so long i've had a lot of other things going
on; there was no unit test for those two functions so I covered them as much as
possible with this test.

(I've triggered a dry run to check that the new test passes everywhere.)

[commit-bot: I haz the power, 2015-09-09 15:53:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-09 15:53:17]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[robert.bradford, 2015-09-09 17:17:20]

The CQ bit was checked by robert.bradford@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-09 17:17:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1266643002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1266643002/80001

[sadrul, 2015-09-09 17:32:07]

https://codereview.chromium.org/1266643002/diff/80001/content/browser/rendere...
File content/browser/renderer_host/web_input_event_aura.h (right):

https://codereview.chromium.org/1266643002/diff/80001/content/browser/rendere...
content/browser/renderer_host/web_input_event_aura.h:41: const
ui::MouseWheelEvent& event);
You don't actually need to expose these functions, right? Just calling
MakeWebMouseEvent() and MakeWebMouseWheelEvent() from the tests should end up
calling these?

[commit-bot: I haz the power, 2015-09-09 17:52:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-09 17:52:48]

Dry run: This issue passed the CQ dry run.

[robert.bradford, 2015-09-10 12:16:50]

On 2015/09/09 17:32:07, sadrul wrote:
>
https://codereview.chromium.org/1266643002/diff/80001/content/browser/rendere...
> File content/browser/renderer_host/web_input_event_aura.h (right):
> 
>
https://codereview.chromium.org/1266643002/diff/80001/content/browser/rendere...
> content/browser/renderer_host/web_input_event_aura.h:41: const
> ui::MouseWheelEvent& event);
> You don't actually need to expose these functions, right? Just calling
> MakeWebMouseEvent() and MakeWebMouseWheelEvent() from the tests should end up
> calling these?

Yes, latest patch set does that now. I misread the windows native event behavior
and thought that that function couldn't be tested directly.

[sadrul, 2015-09-10 18:28:52]

LGTM. Thanks for the tests!

[robert.bradford, 2015-09-11 09:55:35]

The CQ bit was checked by robert.bradford@intel.com

[commit-bot: I haz the power, 2015-09-11 09:55:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1266643002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1266643002/100001

[commit-bot: I haz the power, 2015-09-11 11:14:35]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2015-09-11 11:15:14]

Patchset 5 (id:??) landed as
https://crrev.com/f0cf27e36a998f506342022738902751a19df1cc
Cr-Commit-Position: refs/heads/master@{#348375}

[commit-bot: I haz the power, 2015-09-23 12:21:16]

Patchset 5 (id:??) landed as
https://crrev.com/f0cf27e36a998f506342022738902751a19df1cc
Cr-Commit-Position: refs/heads/master@{#348375}