Short-term fix for CapsLock remapping on chromebooks with external keyboard

chrome/browser/chromeos/preferences.cc

Index: chrome/browser/chromeos/preferences.cc
diff --git a/chrome/browser/chromeos/preferences.cc b/chrome/browser/chromeos/preferences.cc
index 2e1b505716ef452d39ce026482a1bc9c5d58775c..5cf58d238ca50d8be2c6d8f5efc09b1d2d277965 100644
--- a/chrome/browser/chromeos/preferences.cc
+++ b/chrome/browser/chromeos/preferences.cc
@@ -233,9 +233,12 @@ void Preferences::RegisterUserPrefs(PrefRegistrySyncable* registry) {
   registry->RegisterIntegerPref(prefs::kLanguageRemapAltKeyTo,
                                 input_method::kAltKey,
                                 PrefRegistrySyncable::SYNCABLE_PREF);
+  // We don't sync the CapsLock remapping pref, since the UI hides this pref
+  // on certain devices, so syncing a non-default value to a device that
+  // doesn't allow changing the pref would be odd. http://crbug.com/167237
   registry->RegisterIntegerPref(prefs::kLanguageRemapCapsLockKeyTo,

[Yusuke Sato, 2013/03/22 18:42:21]

I think we need to rename kLanguageRemapCapsLockKeyTo in
chrome/common/pref_names.cc and
chrome/browser/resources/options/chromeos/keyboard_overlay.html to
"settings.language.remap_caps_lock_key_to_r2" to avoid the scenario I wrote in
https://code.google.com/p/chromium/issues/detail?id=167237#c12 .

[David Roche, 2013/03/22 19:17:11]

Is changing the pref name really required, since it's no longer sync'd?  Any
build that contains the change to event_rewriter.cc will also contain this
change to avoid sync'ing this pref.

I based this change on one you did a while ago to turn off sync'ing for similar
reasons, and in that CL you only set the pref to UNSYNCHABLE_PREF but left the
pref name as-is.  https://codereview.chromium.org/7013051/

                                 input_method::kCapsLockKey,
-                                PrefRegistrySyncable::SYNCABLE_PREF);
+                                PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterIntegerPref(prefs::kLanguageRemapDiamondKeyTo,
                                 input_method::kControlKey,
                                 PrefRegistrySyncable::SYNCABLE_PREF);