Short-term fix for CapsLock remapping on chromebooks with external keyboard

chrome/browser/chromeos/preferences.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/preferences.h"
 
 #include "ash/magnifier/magnifier_constants.h"
 #include "base/chromeos/chromeos_version.h"
 #include "base/command_line.h"
 #include "base/i18n/time_formatting.h"
@@ skipping 215 matching lines @@
   }
   registry->RegisterIntegerPref(prefs::kLanguageRemapSearchKeyTo,
                                 input_method::kSearchKey,
                                 PrefRegistrySyncable::SYNCABLE_PREF);
   registry->RegisterIntegerPref(prefs::kLanguageRemapControlKeyTo,
                                 input_method::kControlKey,
                                 PrefRegistrySyncable::SYNCABLE_PREF);
   registry->RegisterIntegerPref(prefs::kLanguageRemapAltKeyTo,
                                 input_method::kAltKey,
                                 PrefRegistrySyncable::SYNCABLE_PREF);
+  // We don't sync the CapsLock remapping pref, since the UI hides this pref
+  // on certain devices, so syncing a non-default value to a device that
+  // doesn't allow changing the pref would be odd. http://crbug.com/167237
   registry->RegisterIntegerPref(prefs::kLanguageRemapCapsLockKeyTo,

[Yusuke Sato, 2013/03/22 18:42:21]

I think we need to rename kLanguageRemapCapsLockKeyTo in
chrome/common/pref_names.cc and
chrome/browser/resources/options/chromeos/keyboard_overlay.html to
"settings.language.remap_caps_lock_key_to_r2" to avoid the scenario I wrote in
https://code.google.com/p/chromium/issues/detail?id=167237#c12 .

[David Roche, 2013/03/22 19:17:11]

Is changing the pref name really required, since it's no longer sync'd?  Any
build that contains the change to event_rewriter.cc will also contain this
change to avoid sync'ing this pref.

I based this change on one you did a while ago to turn off sync'ing for similar
reasons, and in that CL you only set the pref to UNSYNCHABLE_PREF but left the
pref name as-is.  https://codereview.chromium.org/7013051/

                                 input_method::kCapsLockKey,
-                                PrefRegistrySyncable::SYNCABLE_PREF);
+                                PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterIntegerPref(prefs::kLanguageRemapDiamondKeyTo,
                                 input_method::kControlKey,
                                 PrefRegistrySyncable::SYNCABLE_PREF);
   // We don't sync the following keyboard prefs since they are not user-
   // configurable.
   registry->RegisterBooleanPref(prefs::kLanguageXkbAutoRepeatEnabled,
                                 true,
                                 PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterIntegerPref(prefs::kLanguageXkbAutoRepeatDelay,
                                 language_prefs::kXkbAutoRepeatDelayInMs,
@@ skipping 622 matching lines @@
 
   input_method::AutoRepeatRate rate;
   rate.initial_delay_in_ms = xkb_auto_repeat_delay_pref_.GetValue();
   rate.repeat_interval_in_ms = xkb_auto_repeat_interval_pref_.GetValue();
   DCHECK(rate.initial_delay_in_ms > 0);
   DCHECK(rate.repeat_interval_in_ms > 0);
   input_method::XKeyboard::SetAutoRepeatRate(rate);
 }
 
 }  // namespace chromeos