extensions/browser/api/management/management_api.cc - Issue 1300763002: Add a flag to enable open in window for hosted apps on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/management/management_api.cc

Issue 1300763002: Add a flag to enable open in window for hosted apps on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@disable-new-bookmark-apps

Patch Set: Addressing reviewer feedback Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/app_list/app_context_menu.cc ('K') | « chrome/test/data/extensions/api_test/management/test/launchType.js ('k') | extensions/browser/api/management/management_api_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/management/management_api.cc

diff --git a/extensions/browser/api/management/management_api.cc b/extensions/browser/api/management/management_api.cc

index 0894837597ce3d78602c8710a5da1922ac07ab8c..424f3477c7998fe01842c3e02b61c3bcac40a5bf 100644

--- a/extensions/browser/api/management/management_api.cc

+++ b/extensions/browser/api/management/management_api.cc

@@ -81,15 +81,14 @@ std::vector<management::LaunchType> GetAvailableLaunchTypes(

launch_type_list.push_back(management::LAUNCH_TYPE_OPEN_AS_REGULAR_TAB);

-#if !defined(OS_MACOSX)

- // Open as window is currently disabled on Mac.

- launch_type_list.push_back(management::LAUNCH_TYPE_OPEN_AS_WINDOW);

+ // TODO(dominickn) remove check when hosted apps can open in windows on Mac.

+ if (delegate->CanHostedAppsOpenInWindows())

benwells 2015/08/19 05:44:54 This logic looks right - we need to make the other

+ launch_type_list.push_back(management::LAUNCH_TYPE_OPEN_AS_WINDOW);

if (!delegate->IsNewBookmarkAppsEnabled()) {

launch_type_list.push_back(management::LAUNCH_TYPE_OPEN_AS_PINNED_TAB);

launch_type_list.push_back(management::LAUNCH_TYPE_OPEN_FULL_SCREEN);

}

-#endif

return launch_type_list;

}