Add a flag to enable open in window for hosted apps on Mac.

extensions/browser/api/management/management_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/management/management_api.h"
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 63 matching lines @@
     const Extension& extension,
     const ManagementAPIDelegate* delegate) {
   std::vector<management::LaunchType> launch_type_list;
   if (extension.is_platform_app()) {
     launch_type_list.push_back(management::LAUNCH_TYPE_OPEN_AS_WINDOW);
     return launch_type_list;
   }
 
   launch_type_list.push_back(management::LAUNCH_TYPE_OPEN_AS_REGULAR_TAB);
 
-#if !defined(OS_MACOSX)
-  // Open as window is currently disabled on Mac.
-  launch_type_list.push_back(management::LAUNCH_TYPE_OPEN_AS_WINDOW);
+  // TODO(dominickn) remove check when hosted apps can open in windows on Mac.
+  if (delegate->CanHostedAppsOpenInWindows())

[benwells, 2015/08/19 05:44:54]

This logic looks right - we need to make the other place match this, I think.

+    launch_type_list.push_back(management::LAUNCH_TYPE_OPEN_AS_WINDOW);
 
   if (!delegate->IsNewBookmarkAppsEnabled()) {
     launch_type_list.push_back(management::LAUNCH_TYPE_OPEN_AS_PINNED_TAB);
     launch_type_list.push_back(management::LAUNCH_TYPE_OPEN_FULL_SCREEN);
   }
-#endif
   return launch_type_list;
 }
 
 scoped_ptr<management::ExtensionInfo> CreateExtensionInfo(
     const Extension& extension,
     content::BrowserContext* context) {
   ExtensionSystem* system = ExtensionSystem::Get(context);
   ExtensionRegistry* registry = ExtensionRegistry::Get(context);
   const ManagementAPIDelegate* delegate =
       ManagementAPI::GetFactoryInstance()->Get(context)->GetDelegate();
@@ skipping 807 matching lines @@
 ManagementAPI::GetFactoryInstance() {
   return g_factory.Pointer();
 }
 
 void ManagementAPI::OnListenerAdded(const EventListenerInfo& details) {
   management_event_router_.reset(new ManagementEventRouter(browser_context_));
   EventRouter::Get(browser_context_)->UnregisterObserver(this);
 }
 
 }  // namespace extensions