chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc - Issue 1300763002: Add a flag to enable open in window for hosted apps on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc

Issue 1300763002: Add a flag to enable open in window for hosted apps on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@disable-new-bookmark-apps

Patch Set: Addressing reviewer feedback Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/app_list/app_context_menu.cc ('K') | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/common/chrome_switches.h » ('j') | extensions/browser/api/management/management_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc

index 61892466e4ade1c5fa17cb396b22ffd783652801..9dec5d6b44765f6682c222ac869513d65a3bfbe2 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc

@@ -66,9 +66,11 @@ LaunchOptionsComboboxModel::LaunchOptionsComboboxModel() {

launch_type_messages_.push_back(

l10n_util::GetStringUTF16(IDS_APP_CONTEXT_MENU_OPEN_TAB));

- launch_types_.push_back(extensions::LAUNCH_TYPE_WINDOW);

- launch_type_messages_.push_back(

- l10n_util::GetStringUTF16(IDS_APP_CONTEXT_MENU_OPEN_WINDOW));

+ if (extensions::util::CanHostedAppsOpenInWindows()) {

+ launch_types_.push_back(extensions::LAUNCH_TYPE_WINDOW);

+ launch_type_messages_.push_back(

+ l10n_util::GetStringUTF16(IDS_APP_CONTEXT_MENU_OPEN_WINDOW));

+ }

} else {

launch_types_.push_back(extensions::LAUNCH_TYPE_REGULAR);

launch_type_messages_.push_back(