Added user settings to chrome://supervised-user-internals.

Added user settings and account info to supervised-user-internals.

Added a full dump of the user settings object to the
chrome://supervised-user-internals page.
Added account information for all accounts the profile has to the same page.

Additionally, updated SupervisedUserService::Subscribe to return a CallbackList<>::Subscription so subscribers can unsubscribe.

BUG=495093
Committed: https://crrev.com/af7bd688dba485f5e8e2b3c9781e439dbbac8ea5
Cr-Commit-Position: refs/heads/master@{#344203}

[PEConn2, 2015-08-17 17:08:46]

peconn@google.com changed reviewers:
+ bauerb@chromium.org

[Bernhard Bauer, 2015-08-18 13:09:09]

Nice!

https://codereview.chromium.org/1300643002/diff/1/chrome/browser/resources/su...
File chrome/browser/resources/supervised_user_internals.html (right):

https://codereview.chromium.org/1300643002/diff/1/chrome/browser/resources/su...
chrome/browser/resources/supervised_user_internals.html:48: <h2>User
Settings</h2>
Nit: I would call this section "Supervised User Settings".

https://codereview.chromium.org/1300643002/diff/1/chrome/browser/resources/su...
File chrome/browser/resources/supervised_user_internals.js (right):

https://codereview.chromium.org/1300643002/diff/1/chrome/browser/resources/su...
chrome/browser/resources/supervised_user_internals.js:59: kvpairs.push({
You could do this with Object.keys(settings).map(function(key) { ... });

https://codereview.chromium.org/1300643002/diff/1/chrome/browser/ui/webui/sup...
File chrome/browser/ui/webui/supervised_user_internals_message_handler.cc
(right):

https://codereview.chromium.org/1300643002/diff/1/chrome/browser/ui/webui/sup...
chrome/browser/ui/webui/supervised_user_internals_message_handler.cc:254:
SupervisedUserSettingsServiceFactory::GetForProfile(profile);
Nit: Broken lines are indentend four spaces.

https://codereview.chromium.org/1300643002/diff/1/chrome/browser/ui/webui/sup...
chrome/browser/ui/webui/supervised_user_internals_message_handler.cc:255:
settings_service->Subscribe(base::Bind(
Hm... any time we open this page, this will subscribe a new callback, which is
then no-op'ed out when this object is destroyed, but is still subscribed,
essentially making this a (small) leak. Maybe we should change the interface to
SupervisedUserSettingsService so that it allows unsubscription, e.g. by
returning a base::CallbackList::Subscription. But we can do that in a separate
CL and rebase this one on top, or do it in a followup CL (but in that case we
should add a TODO here).

[Bernhard Bauer, 2015-08-18 13:11:01]

Also, please add BUG=495093.

Also^2, you may want to upload future CLs under your Chromium account (I don't
think you can change the owner for this one).

[PEConn2, 2015-08-18 14:02:58]

https://codereview.chromium.org/1300643002/diff/1/chrome/browser/resources/su...
File chrome/browser/resources/supervised_user_internals.html (right):

https://codereview.chromium.org/1300643002/diff/1/chrome/browser/resources/su...
chrome/browser/resources/supervised_user_internals.html:48: <h2>User
Settings</h2>
On 2015/08/18 13:09:09, Bernhard Bauer wrote:
> Nit: I would call this section "Supervised User Settings".

Done.

https://codereview.chromium.org/1300643002/diff/1/chrome/browser/resources/su...
File chrome/browser/resources/supervised_user_internals.js (right):

https://codereview.chromium.org/1300643002/diff/1/chrome/browser/resources/su...
chrome/browser/resources/supervised_user_internals.js:59: kvpairs.push({
On 2015/08/18 13:09:09, Bernhard Bauer wrote:
> You could do this with Object.keys(settings).map(function(key) { ... });

Done.

https://codereview.chromium.org/1300643002/diff/1/chrome/browser/ui/webui/sup...
File chrome/browser/ui/webui/supervised_user_internals_message_handler.cc
(right):

https://codereview.chromium.org/1300643002/diff/1/chrome/browser/ui/webui/sup...
chrome/browser/ui/webui/supervised_user_internals_message_handler.cc:254:
SupervisedUserSettingsServiceFactory::GetForProfile(profile);
On 2015/08/18 13:09:09, Bernhard Bauer wrote:
> Nit: Broken lines are indentend four spaces.

Done.

https://codereview.chromium.org/1300643002/diff/1/chrome/browser/ui/webui/sup...
chrome/browser/ui/webui/supervised_user_internals_message_handler.cc:255:
settings_service->Subscribe(base::Bind(
On 2015/08/18 13:09:09, Bernhard Bauer wrote:
> Hm... any time we open this page, this will subscribe a new callback, which is
> then no-op'ed out when this object is destroyed, but is still subscribed,
> essentially making this a (small) leak. Maybe we should change the interface
to
> SupervisedUserSettingsService so that it allows unsubscription, e.g. by
> returning a base::CallbackList::Subscription. But we can do that in a separate
> CL and rebase this one on top, or do it in a followup CL (but in that case we
> should add a TODO here).

Done.

[Bernhard Bauer, 2015-08-18 15:39:23]

On 2015/08/18 13:11:01, Bernhard Bauer wrote:
> Also, please add BUG=495093.

^^^

https://codereview.chromium.org/1300643002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/supervised_user_internals_message_handler.cc
(right):

https://codereview.chromium.org/1300643002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/supervised_user_internals_message_handler.cc:255: //
TODO: Change interface to SupervisedUserSettingsService to allow
Nit: Write TODOs in the form TODO(ldap), so it's easier to grep for them. And
BTW, the ldap doesn't actually have to be yours; it's the person who can be
contacted about the TODO, so feel free to make it TODO(bauerb).

[Bernhard Bauer, 2015-08-18 16:11:11]

LGTM, but your CL description could get cleaned up a bit, I think (it kinda
looks like three different version of the same description got smooshed
together).

[Bernhard Bauer, 2015-08-18 17:20:47]

lgtm

[PEConn2, 2015-08-19 10:38:49]

The CQ bit was checked by peconn@google.com

[commit-bot: I haz the power, 2015-08-19 10:39:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1300643002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1300643002/60001

[commit-bot: I haz the power, 2015-08-19 11:45:49]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-08-19 11:46:39]

Patchset 4 (id:??) landed as
https://crrev.com/af7bd688dba485f5e8e2b3c9781e439dbbac8ea5
Cr-Commit-Position: refs/heads/master@{#344203}

[Bernhard Bauer, 2015-08-19 14:39:03]

On 2015/08/19 14:22:10, PEConn wrote:

I think you want to upload this to a new CL. Either create a new branch, or
merge with trunk and delete the issue association (with `git cl issue 0`).