Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: chrome/browser/supervised_user/supervised_user_settings_service.cc

Issue 1300643002: Added user settings to chrome://supervised-user-internals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: SupervisedUserSettingsService supports unsubscription Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/supervised_user/supervised_user_settings_service.cc
diff --git a/chrome/browser/supervised_user/supervised_user_settings_service.cc b/chrome/browser/supervised_user/supervised_user_settings_service.cc
index 40eb8ac3def658317f9f666a9de95949246d9757..239d2914ee82b03d5dea0347c7a1470aa10f0825 100644
--- a/chrome/browser/supervised_user/supervised_user_settings_service.cc
+++ b/chrome/browser/supervised_user/supervised_user_settings_service.cc
@@ -85,14 +85,15 @@ void SupervisedUserSettingsService::Init(
store_->AddObserver(this);
}
-void SupervisedUserSettingsService::Subscribe(
+scoped_ptr<SupervisedUserSettingsService::SettingsCallbackList::Subscription>
+ SupervisedUserSettingsService::Subscribe(
const SettingsCallback& callback) {
if (IsReady()) {
scoped_ptr<base::DictionaryValue> settings = GetSettings();
callback.Run(settings.get());
}
- subscribers_.push_back(callback);
+ return callback_list_.Add(callback);
}
void SupervisedUserSettingsService::SetActive(bool active) {
@@ -406,6 +407,5 @@ void SupervisedUserSettingsService::InformSubscribers() {
return;
scoped_ptr<base::DictionaryValue> settings = GetSettings();
- for (const auto& callback : subscribers_)
- callback.Run(settings.get());
+ callback_list_.Notify(settings.get());
}

Powered by Google App Engine
This is Rietveld 408576698