chrome/browser/sync/glue/favicon_cache_unittest.cc - Issue 13006012: [Sync] Fix double tranaction acquire in favicon code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/favicon_cache_unittest.cc

Issue 13006012: [Sync] Fix double tranaction acquire in favicon code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/glue/favicon_cache_unittest.cc

diff --git a/chrome/browser/sync/glue/favicon_cache_unittest.cc b/chrome/browser/sync/glue/favicon_cache_unittest.cc

index f7c146bca8657b16d1c5fde3c349689380ad2908..fa2450e6a8dbfd4ab8f5265a2eda8a1357139452 100644

--- a/chrome/browser/sync/glue/favicon_cache_unittest.cc

+++ b/chrome/browser/sync/glue/favicon_cache_unittest.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/sync/glue/favicon_cache.h"

+#include "base/message_loop.h"

#include "base/stringprintf.h"

#include "chrome/browser/history/history_notifications.h"

#include "chrome/common/chrome_notification_types.h"

@@ -287,6 +288,7 @@ class SyncFaviconCacheTest : public testing::Test {

void OnCustomFaviconDataAvailable(const TestFaviconData& test_data);

private:

+ MessageLoopForUI message_loop_;

rlarocque 2013/03/25 21:30:57 Is this used anywhere?

Nicolas Zea 2013/03/25 21:37:30 It's necessary so that MessageLoop::current() does

FaviconCache cache_;

// Our dummy ChangeProcessor used to inspect changes pushed to Sync.

« no previous file with comments | « chrome/browser/sync/glue/favicon_cache.cc ('k') | no next file » | no next file with comments »