[Sync] Fix double tranaction acquire in favicon code

chrome/browser/sync/glue/favicon_cache_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/glue/favicon_cache.h"
 
+#include "base/message_loop.h"
 #include "base/stringprintf.h"
 #include "chrome/browser/history/history_notifications.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "content/public/browser/notification_service.h"
 #include "sync/api/sync_error_factory_mock.h"
 #include "sync/protocol/favicon_image_specifics.pb.h"
 #include "sync/protocol/favicon_tracking_specifics.pb.h"
 #include "sync/protocol/sync.pb.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 263 matching lines @@
   scoped_ptr<syncer::SyncChangeProcessor> CreateAndPassProcessor();
   scoped_ptr<syncer::SyncErrorFactory> CreateAndPassSyncErrorFactory();
 
   FaviconCache* cache() { return &cache_; }
   TestChangeProcessor* processor() { return sync_processor_.get(); }
 
   // Finish an outstanding favicon load for the icon described in |test_data|.
   void OnCustomFaviconDataAvailable(const TestFaviconData& test_data);
 
  private:
+  MessageLoopForUI message_loop_;

[rlarocque, 2013/03/25 21:30:57]

Is this used anywhere?

[Nicolas Zea, 2013/03/25 21:37:30]

It's necessary so that MessageLoop::current() doesn't return null.

   FaviconCache cache_;
 
   // Our dummy ChangeProcessor used to inspect changes pushed to Sync.
   scoped_ptr<TestChangeProcessor> sync_processor_;
   scoped_ptr<SyncChangeProcessorDelegate> sync_processor_delegate_;
 };
 
 SyncFaviconCacheTest::SyncFaviconCacheTest()
     : cache_(NULL, kMaxSyncFavicons),
       sync_processor_(new TestChangeProcessor),
@@ skipping 1089 matching lines @@
                 expected_deletions,
                 expected_icons,
                 changes_1);
   VerifyChanges(syncer::FAVICON_TRACKING,
                 expected_deletions,
                 expected_icons,
                 changes_2);
 }
 
 }  // namespace browser_sync