chrome/browser/sync/glue/favicon_cache.h - Issue 13006012: [Sync] Fix double tranaction acquire in favicon code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/favicon_cache.h

Issue 13006012: [Sync] Fix double tranaction acquire in favicon code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/glue/favicon_cache.h

diff --git a/chrome/browser/sync/glue/favicon_cache.h b/chrome/browser/sync/glue/favicon_cache.h

index b7c8f7c27e92322c0f57ae736e2bfd34c3cfbb3c..1ac5db7e3426517907697d5c81e96d30b6b094c9 100644

--- a/chrome/browser/sync/glue/favicon_cache.h

+++ b/chrome/browser/sync/glue/favicon_cache.h

@@ -100,6 +100,7 @@ class FaviconCache : public syncer::SyncableService,

// Consume Session sync favicon data. Will not overwrite existing favicons.

// If |icon_bytes| is empty, only updates the page->favicon url mapping.

+ // Safe to call within a transaction.

void OnReceivedSyncFavicon(const GURL& page_url,

const GURL& icon_url,

const std::string& icon_bytes,