Issue 1300583002: Improve samplerParameter[if] in WebGL2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1300583002: Improve samplerParameter[if] in WebGL2 (Closed)

Created:
5 years, 4 months ago by legend

Modified:
5 years, 4 months ago

Reviewers:
Ken Russell (switch to Gerrit), Zhenyao Mo, bajones

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Improve samplerParameter[if] in WebGL2 Integrate samplerParameter[if] functions and validate the pname in blink. BUG=295792 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200790

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -7 lines)			Patch
	M	Source/modules/webgl/WebGL2RenderingContextBase.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	Source/modules/webgl/WebGL2RenderingContextBase.cpp	View		3 chunks	+35 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

legend

PTAL. The related conformance test is added at https://github.com/KhronosGroup/WebGL/pull/1151.

5 years, 4 months ago (2015-08-17 07:09:03 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300583002/1

5 years, 4 months ago (2015-08-19 01:41:00 UTC) #5

commit-bot: I haz the power

5 years, 4 months ago (2015-08-19 03:39:12 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200790

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages