Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1300523002: Revert[7] "move some public headers into private" (Closed)

Created:
5 years, 4 months ago by reed2
Modified:
5 years, 4 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert[7] "move some public headers into private" This reverts commit e02716908fe82c7c4ae9b415793277620a22bcd6. BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/fb28cd2b13d76c324570341e1155aaadc1b532b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -655 lines) Patch
M gyp/animator.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/core.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M gyp/sfnt.gyp View 1 chunk +0 lines, -1 line 0 comments Download
A + include/core/SkEndian.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + include/core/SkFloatBits.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + include/core/SkFloatingPoint.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M include/core/SkPicture.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkScalar.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkTypeface.h View 1 chunk +1 line, -1 line 0 comments Download
A + include/core/SkWeakRefCnt.h View 0 chunks +-1 lines, --1 lines 0 comments Download
D include/private/SkFloatBits.h View 1 chunk +0 lines, -132 lines 0 comments Download
D include/private/SkFloatingPoint.h View 1 chunk +0 lines, -170 lines 0 comments Download
D include/private/SkWeakRefCnt.h View 1 chunk +0 lines, -159 lines 0 comments Download
M include/svg/parser/SkSVGParser.h View 1 chunk +1 line, -0 lines 0 comments Download
D src/core/SkEndian.h View 1 chunk +0 lines, -194 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
reed2
../../chromecast/browser/test/chromecast_browser_test.cc:12: In file included from ../../chromecast/browser/cast_content_window.h:10: In file included from ../../content/public/browser/web_contents_observer.h:16: In file included from ...
5 years, 4 months ago (2015-08-15 15:39:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300523002/1
5 years, 4 months ago (2015-08-15 15:39:50 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-15 15:46:31 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fb28cd2b13d76c324570341e1155aaadc1b532b6

Powered by Google App Engine
This is Rietveld 408576698