Add constant info to the dart2js_info model

Add constant info to the dart2js_info model

R=het@google.com

Committed: https://github.com/dart-lang/dart2js_info/commit/2950e788d8e093b7fbb322818663bb582c706b9f

[Siggi Cherem (dart-lang), 2015-08-18 23:59:20]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2015-08-18 23:59:57]

sigmund@google.com changed reviewers:
+ het@google.com

[Siggi Cherem (dart-lang), 2015-08-18 23:59:57]

I'll send a separate CL later that will extract this information in the dumpinfo
task

[Siggi Cherem (dart-lang), 2015-08-19 15:06:48]

sigmund@google.com changed reviewers:
+ johnniwinther@google.com

[Harry Terkelsen, 2015-08-19 17:41:31]

https://codereview.chromium.org/1300513005/diff/40001/bin/library_size_split....
File bin/library_size_split.dart (right):

https://codereview.chromium.org/1300513005/diff/40001/bin/library_size_split....
bin/library_size_split.dart:114: var longest = 0;
var longest = 'Program Size'.length;

and then remove `longest = max(0, 'Program Size'.length)` below

https://codereview.chromium.org/1300513005/diff/40001/lib/info.dart
File lib/info.dart (right):

https://codereview.chromium.org/1300513005/diff/40001/lib/info.dart#newcode332
lib/info.dart:332: ..isConst = json['const'] ?? false
also add a todo to remove '?? false' on next breaking version

https://codereview.chromium.org/1300513005/diff/40001/lib/info.dart#newcode498
lib/info.dart:498: static int _ids = 0;
I'm not clear on why constants get their own ids separate from the rest of the
Infos. Won't this mess up serialization?

https://codereview.chromium.org/1300513005/diff/40001/lib/info.dart#newcode510
lib/info.dart:510: ..addAll({
weird formatting, is this what dartfmt outputs?

[Siggi Cherem (dart-lang), 2015-08-19 19:31:15]

https://codereview.chromium.org/1300513005/diff/40001/bin/library_size_split....
File bin/library_size_split.dart (right):

https://codereview.chromium.org/1300513005/diff/40001/bin/library_size_split....
bin/library_size_split.dart:114: var longest = 0;
On 2015/08/19 17:41:31, Harry Terkelsen wrote:
> var longest = 'Program Size'.length;
> 
> and then remove `longest = max(0, 'Program Size'.length)` below

Ah - sorry, I meant to remove that line :) - it's now handled by _addRow.

Good catch!

https://codereview.chromium.org/1300513005/diff/40001/lib/info.dart
File lib/info.dart (right):

https://codereview.chromium.org/1300513005/diff/40001/lib/info.dart#newcode332
lib/info.dart:332: ..isConst = json['const'] ?? false
On 2015/08/19 17:41:31, Harry Terkelsen wrote:
> also add a todo to remove '?? false' on next breaking version

Since it was a boolean, I was thinking that we would not generate 'const': false
in the json even when we do a breaking version. That way we can keep the json
size smaller.

WDYT?

https://codereview.chromium.org/1300513005/diff/40001/lib/info.dart#newcode498
lib/info.dart:498: static int _ids = 0;
On 2015/08/19 17:41:31, Harry Terkelsen wrote:
> I'm not clear on why constants get their own ids separate from the rest of the
> Infos. Won't this mess up serialization?

Note that every info kind has their own separate id counter. We always use the
full id with the kind prefix to identify each element (e.g. 'const/32').

https://codereview.chromium.org/1300513005/diff/40001/lib/info.dart#newcode510
lib/info.dart:510: ..addAll({
On 2015/08/19 17:41:31, Harry Terkelsen wrote:
> weird formatting, is this what dartfmt outputs?

sorry, my faull. I've fixed this line for now, but I'll run the formatter on the
entire repo after submitting this.

[Harry Terkelsen, 2015-08-19 19:34:58]

lgtm

https://codereview.chromium.org/1300513005/diff/40001/lib/info.dart
File lib/info.dart (right):

https://codereview.chromium.org/1300513005/diff/40001/lib/info.dart#newcode332
lib/info.dart:332: ..isConst = json['const'] ?? false
On 2015/08/19 19:31:15, Siggi Cherem (dart-lang) wrote:
> On 2015/08/19 17:41:31, Harry Terkelsen wrote:
> > also add a todo to remove '?? false' on next breaking version
> 
> Since it was a boolean, I was thinking that we would not generate 'const':
false
> in the json even when we do a breaking version. That way we can keep the json
> size smaller.
> 
> WDYT?

sgtm

https://codereview.chromium.org/1300513005/diff/40001/lib/info.dart#newcode498
lib/info.dart:498: static int _ids = 0;
On 2015/08/19 19:31:15, Siggi Cherem (dart-lang) wrote:
> On 2015/08/19 17:41:31, Harry Terkelsen wrote:
> > I'm not clear on why constants get their own ids separate from the rest of
the
> > Infos. Won't this mess up serialization?
> 
> Note that every info kind has their own separate id counter. We always use the
> full id with the kind prefix to identify each element (e.g. 'const/32').

Acknowledged.

[Siggi Cherem (dart-lang), 2015-08-19 19:43:03]

Committed patchset #3 (id:60001) manually as
2950e788d8e093b7fbb322818663bb582c706b9f (presubmit successful).

[Siggi Cherem (dart-lang), 2015-08-19 19:53:40]

https://codereview.chromium.org/1300513005/diff/40001/lib/info.dart
File lib/info.dart (right):

https://codereview.chromium.org/1300513005/diff/40001/lib/info.dart#newcode510
lib/info.dart:510: ..addAll({
On 2015/08/19 19:31:15, Siggi Cherem (dart-lang) wrote:
> On 2015/08/19 17:41:31, Harry Terkelsen wrote:
> > weird formatting, is this what dartfmt outputs?
> 
> sorry, my faull. I've fixed this line for now, but I'll run the formatter on
the
> entire repo after submitting this.

FYI - I pushed the formatter changes directly (here is the commit
https://github.com/dart-lang/dart2js_info/commit/cf9395226d886d2a5faf78ae2799...)