Issue 1300403002: Add a few more expectations to crashpad_util_test InRangeCast

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1300403002: Add a few more expectations to crashpad_util_test InRangeCast (Closed)

Created:
5 years, 4 months ago by Mark Mentovai

Modified:
5 years, 4 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

Add a few more expectations to crashpad_util_test InRangeCast TEST=crashpad_util_test InRangeCast.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/b70d3029874f671d0eb4d0c00ec628d92c6a1c1f

Patch Set 1 #

Total comments: 1

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	util/numeric/in_range_cast_test.cc	View		4 chunks	+5 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Mark Mentovai

https://codereview.chromium.org/1300403002/diff/1/util/numeric/in_range_cast_test.cc File util/numeric/in_range_cast_test.cc (left): https://codereview.chromium.org/1300403002/diff/1/util/numeric/in_range_cast_test.cc#oldcode82 util/numeric/in_range_cast_test.cc:82: EXPECT_EQ(1u, InRangeCast<uint64_t>(kInt32Min, 1)); This was a duplicate.

5 years, 4 months ago (2015-08-20 15:52:59 UTC) #2

Mark Mentovai

5 years, 4 months ago (2015-08-20 16:13:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b70d3029874f671d0eb4d0c00ec628d92c6a1c1f (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages