 Chromium Code Reviews
 Chromium Code Reviews Issue 1300403002:
  Add a few more expectations to crashpad_util_test InRangeCast  (Closed) 
  Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
    
  
    Issue 1300403002:
  Add a few more expectations to crashpad_util_test InRangeCast  (Closed) 
  Base URL: https://chromium.googlesource.com/crashpad/crashpad@master| OLD | NEW | 
|---|---|
| 1 // Copyright 2014 The Crashpad Authors. All rights reserved. | 1 // Copyright 2014 The Crashpad Authors. All rights reserved. | 
| 2 // | 2 // | 
| 3 // Licensed under the Apache License, Version 2.0 (the "License"); | 3 // Licensed under the Apache License, Version 2.0 (the "License"); | 
| 4 // you may not use this file except in compliance with the License. | 4 // you may not use this file except in compliance with the License. | 
| 5 // You may obtain a copy of the License at | 5 // You may obtain a copy of the License at | 
| 6 // | 6 // | 
| 7 // http://www.apache.org/licenses/LICENSE-2.0 | 7 // http://www.apache.org/licenses/LICENSE-2.0 | 
| 8 // | 8 // | 
| 9 // Unless required by applicable law or agreed to in writing, software | 9 // Unless required by applicable law or agreed to in writing, software | 
| 10 // distributed under the License is distributed on an "AS IS" BASIS, | 10 // distributed under the License is distributed on an "AS IS" BASIS, | 
| (...skipping 21 matching lines...) Expand all Loading... | |
| 32 EXPECT_EQ(1u, InRangeCast<uint32_t>(1, 1)); | 32 EXPECT_EQ(1u, InRangeCast<uint32_t>(1, 1)); | 
| 33 EXPECT_EQ(2u, InRangeCast<uint32_t>(2, 1)); | 33 EXPECT_EQ(2u, InRangeCast<uint32_t>(2, 1)); | 
| 34 EXPECT_EQ(0u, InRangeCast<uint32_t>(-1, 0)); | 34 EXPECT_EQ(0u, InRangeCast<uint32_t>(-1, 0)); | 
| 35 EXPECT_EQ(1u, InRangeCast<uint32_t>(-1, 1)); | 35 EXPECT_EQ(1u, InRangeCast<uint32_t>(-1, 1)); | 
| 36 EXPECT_EQ(2u, InRangeCast<uint32_t>(-1, 2)); | 36 EXPECT_EQ(2u, InRangeCast<uint32_t>(-1, 2)); | 
| 37 EXPECT_EQ(0xffffffffu, InRangeCast<uint32_t>(0xffffffffu, 1)); | 37 EXPECT_EQ(0xffffffffu, InRangeCast<uint32_t>(0xffffffffu, 1)); | 
| 38 EXPECT_EQ(0xffffffffu, InRangeCast<uint32_t>(UINT64_C(0xffffffff), 1)); | 38 EXPECT_EQ(0xffffffffu, InRangeCast<uint32_t>(UINT64_C(0xffffffff), 1)); | 
| 39 EXPECT_EQ(1u, InRangeCast<uint32_t>(UINT64_C(0x100000000), 1)); | 39 EXPECT_EQ(1u, InRangeCast<uint32_t>(UINT64_C(0x100000000), 1)); | 
| 40 EXPECT_EQ(1u, InRangeCast<uint32_t>(UINT64_C(0x100000001), 1)); | 40 EXPECT_EQ(1u, InRangeCast<uint32_t>(UINT64_C(0x100000001), 1)); | 
| 41 EXPECT_EQ(1u, InRangeCast<uint32_t>(kInt32Min, 1)); | 41 EXPECT_EQ(1u, InRangeCast<uint32_t>(kInt32Min, 1)); | 
| 42 EXPECT_EQ(1u, InRangeCast<uint32_t>(kInt64Min, 1)); | |
| 42 EXPECT_EQ(0xffffffffu, InRangeCast<uint32_t>(-1, 0xffffffffu)); | 43 EXPECT_EQ(0xffffffffu, InRangeCast<uint32_t>(-1, 0xffffffffu)); | 
| 43 } | 44 } | 
| 44 | 45 | 
| 45 TEST(InRangeCast, Int32) { | 46 TEST(InRangeCast, Int32) { | 
| 46 EXPECT_EQ(0, InRangeCast<int32_t>(0, 1)); | 47 EXPECT_EQ(0, InRangeCast<int32_t>(0, 1)); | 
| 47 EXPECT_EQ(1, InRangeCast<int32_t>(1, 1)); | 48 EXPECT_EQ(1, InRangeCast<int32_t>(1, 1)); | 
| 48 EXPECT_EQ(2, InRangeCast<int32_t>(2, 1)); | 49 EXPECT_EQ(2, InRangeCast<int32_t>(2, 1)); | 
| 49 EXPECT_EQ(-1, InRangeCast<int32_t>(-1, 1)); | 50 EXPECT_EQ(-1, InRangeCast<int32_t>(-1, 1)); | 
| 50 EXPECT_EQ(0x7fffffff, InRangeCast<int32_t>(0x7fffffff, 1)); | 51 EXPECT_EQ(0x7fffffff, InRangeCast<int32_t>(0x7fffffff, 1)); | 
| 51 EXPECT_EQ(0x7fffffff, InRangeCast<int32_t>(0x7fffffffu, 1)); | 52 EXPECT_EQ(0x7fffffff, InRangeCast<int32_t>(0x7fffffffu, 1)); | 
| 52 EXPECT_EQ(1, InRangeCast<int32_t>(0x80000000u, 1)); | 53 EXPECT_EQ(1, InRangeCast<int32_t>(0x80000000u, 1)); | 
| 53 EXPECT_EQ(1, InRangeCast<int32_t>(0xffffffffu, 1)); | 54 EXPECT_EQ(1, InRangeCast<int32_t>(0xffffffffu, 1)); | 
| 54 EXPECT_EQ(1, InRangeCast<int32_t>(INT64_C(0x80000000), 1)); | 55 EXPECT_EQ(1, InRangeCast<int32_t>(INT64_C(0x80000000), 1)); | 
| 55 EXPECT_EQ(1, InRangeCast<int32_t>(INT64_C(0xffffffff), 1)); | 56 EXPECT_EQ(1, InRangeCast<int32_t>(INT64_C(0xffffffff), 1)); | 
| 56 EXPECT_EQ(1, InRangeCast<int32_t>(INT64_C(0x100000000), 1)); | 57 EXPECT_EQ(1, InRangeCast<int32_t>(INT64_C(0x100000000), 1)); | 
| 57 EXPECT_EQ(kInt32Min, InRangeCast<int32_t>(kInt32Min, 1)); | 58 EXPECT_EQ(kInt32Min, InRangeCast<int32_t>(kInt32Min, 1)); | 
| 58 EXPECT_EQ(kInt32Min, | 59 EXPECT_EQ(kInt32Min, | 
| 59 InRangeCast<int32_t>(implicit_cast<int64_t>(kInt32Min), 1)); | 60 InRangeCast<int32_t>(implicit_cast<int64_t>(kInt32Min), 1)); | 
| 60 EXPECT_EQ(1, InRangeCast<int32_t>(implicit_cast<int64_t>(kInt32Min) - 1, 1)); | 61 EXPECT_EQ(1, InRangeCast<int32_t>(implicit_cast<int64_t>(kInt32Min) - 1, 1)); | 
| 62 EXPECT_EQ(1, InRangeCast<int32_t>(kInt64Min, 1)); | |
| 61 EXPECT_EQ(0, InRangeCast<int32_t>(0xffffffffu, 0)); | 63 EXPECT_EQ(0, InRangeCast<int32_t>(0xffffffffu, 0)); | 
| 62 EXPECT_EQ(-1, InRangeCast<int32_t>(0xffffffffu, -1)); | 64 EXPECT_EQ(-1, InRangeCast<int32_t>(0xffffffffu, -1)); | 
| 63 EXPECT_EQ(kInt32Min, InRangeCast<int32_t>(0xffffffffu, kInt32Min)); | 65 EXPECT_EQ(kInt32Min, InRangeCast<int32_t>(0xffffffffu, kInt32Min)); | 
| 64 EXPECT_EQ(0x7fffffff, InRangeCast<int32_t>(0xffffffffu, 0x7fffffff)); | 66 EXPECT_EQ(0x7fffffff, InRangeCast<int32_t>(0xffffffffu, 0x7fffffff)); | 
| 65 } | 67 } | 
| 66 | 68 | 
| 67 TEST(InRangeCast, Uint64) { | 69 TEST(InRangeCast, Uint64) { | 
| 68 EXPECT_EQ(0u, InRangeCast<uint64_t>(0, 1)); | 70 EXPECT_EQ(0u, InRangeCast<uint64_t>(0, 1)); | 
| 69 EXPECT_EQ(1u, InRangeCast<uint64_t>(1, 1)); | 71 EXPECT_EQ(1u, InRangeCast<uint64_t>(1, 1)); | 
| 70 EXPECT_EQ(2u, InRangeCast<uint64_t>(2, 1)); | 72 EXPECT_EQ(2u, InRangeCast<uint64_t>(2, 1)); | 
| 71 EXPECT_EQ(0u, InRangeCast<uint64_t>(-1, 0)); | 73 EXPECT_EQ(0u, InRangeCast<uint64_t>(-1, 0)); | 
| 72 EXPECT_EQ(1u, InRangeCast<uint64_t>(-1, 1)); | 74 EXPECT_EQ(1u, InRangeCast<uint64_t>(-1, 1)); | 
| 73 EXPECT_EQ(2u, InRangeCast<uint64_t>(-1, 2)); | 75 EXPECT_EQ(2u, InRangeCast<uint64_t>(-1, 2)); | 
| 74 EXPECT_EQ(0xffffffffu, InRangeCast<uint64_t>(0xffffffffu, 1)); | 76 EXPECT_EQ(0xffffffffu, InRangeCast<uint64_t>(0xffffffffu, 1)); | 
| 75 EXPECT_EQ(0xffffffffu, InRangeCast<uint64_t>(UINT64_C(0xffffffff), 1)); | 77 EXPECT_EQ(0xffffffffu, InRangeCast<uint64_t>(UINT64_C(0xffffffff), 1)); | 
| 76 EXPECT_EQ(UINT64_C(0x100000000), | 78 EXPECT_EQ(UINT64_C(0x100000000), | 
| 77 InRangeCast<uint64_t>(UINT64_C(0x100000000), 1)); | 79 InRangeCast<uint64_t>(UINT64_C(0x100000000), 1)); | 
| 78 EXPECT_EQ(UINT64_C(0x100000001), | 80 EXPECT_EQ(UINT64_C(0x100000001), | 
| 79 InRangeCast<uint64_t>(UINT64_C(0x100000001), 1)); | 81 InRangeCast<uint64_t>(UINT64_C(0x100000001), 1)); | 
| 80 EXPECT_EQ(1u, InRangeCast<uint64_t>(kInt32Min, 1)); | 82 EXPECT_EQ(1u, InRangeCast<uint64_t>(kInt32Min, 1)); | 
| 81 EXPECT_EQ(1u, InRangeCast<uint64_t>(INT64_C(-1), 1)); | 83 EXPECT_EQ(1u, InRangeCast<uint64_t>(INT64_C(-1), 1)); | 
| 82 EXPECT_EQ(1u, InRangeCast<uint64_t>(kInt32Min, 1)); | |
| 
Mark Mentovai
2015/08/20 15:52:59
This was a duplicate.
 | |
| 83 EXPECT_EQ(1u, InRangeCast<uint64_t>(kInt64Min, 1)); | 84 EXPECT_EQ(1u, InRangeCast<uint64_t>(kInt64Min, 1)); | 
| 84 EXPECT_EQ(UINT64_C(0xffffffffffffffff), | 85 EXPECT_EQ(UINT64_C(0xffffffffffffffff), | 
| 85 InRangeCast<uint64_t>(-1, UINT64_C(0xffffffffffffffff))); | 86 InRangeCast<uint64_t>(-1, UINT64_C(0xffffffffffffffff))); | 
| 86 } | 87 } | 
| 87 | 88 | 
| 88 TEST(InRangeCast, Int64) { | 89 TEST(InRangeCast, Int64) { | 
| 89 EXPECT_EQ(0, InRangeCast<int64_t>(0, 1)); | 90 EXPECT_EQ(0, InRangeCast<int64_t>(0, 1)); | 
| 90 EXPECT_EQ(1, InRangeCast<int64_t>(1, 1)); | 91 EXPECT_EQ(1, InRangeCast<int64_t>(1, 1)); | 
| 91 EXPECT_EQ(2, InRangeCast<int64_t>(2, 1)); | 92 EXPECT_EQ(2, InRangeCast<int64_t>(2, 1)); | 
| 92 EXPECT_EQ(-1, InRangeCast<int64_t>(-1, 1)); | 93 EXPECT_EQ(-1, InRangeCast<int64_t>(-1, 1)); | 
| 93 EXPECT_EQ(0x7fffffff, InRangeCast<int64_t>(0x7fffffff, 1)); | 94 EXPECT_EQ(0x7fffffff, InRangeCast<int64_t>(0x7fffffff, 1)); | 
| 94 EXPECT_EQ(0x7fffffff, InRangeCast<int64_t>(0x7fffffffu, 1)); | 95 EXPECT_EQ(0x7fffffff, InRangeCast<int64_t>(0x7fffffffu, 1)); | 
| 95 EXPECT_EQ(INT64_C(0x80000000), InRangeCast<int64_t>(0x80000000u, 1)); | 96 EXPECT_EQ(INT64_C(0x80000000), InRangeCast<int64_t>(0x80000000u, 1)); | 
| 96 EXPECT_EQ(INT64_C(0xffffffff), InRangeCast<int64_t>(0xffffffffu, 1)); | 97 EXPECT_EQ(INT64_C(0xffffffff), InRangeCast<int64_t>(0xffffffffu, 1)); | 
| 97 EXPECT_EQ(INT64_C(0x80000000), InRangeCast<int64_t>(INT64_C(0x80000000), 1)); | 98 EXPECT_EQ(INT64_C(0x80000000), InRangeCast<int64_t>(INT64_C(0x80000000), 1)); | 
| 98 EXPECT_EQ(INT64_C(0xffffffff), InRangeCast<int64_t>(INT64_C(0xffffffff), 1)); | 99 EXPECT_EQ(INT64_C(0xffffffff), InRangeCast<int64_t>(INT64_C(0xffffffff), 1)); | 
| 99 EXPECT_EQ(INT64_C(0x100000000), | 100 EXPECT_EQ(INT64_C(0x100000000), | 
| 100 InRangeCast<int64_t>(INT64_C(0x100000000), 1)); | 101 InRangeCast<int64_t>(INT64_C(0x100000000), 1)); | 
| 101 EXPECT_EQ(INT64_C(0x7fffffffffffffff), | 102 EXPECT_EQ(INT64_C(0x7fffffffffffffff), | 
| 102 InRangeCast<int64_t>(INT64_C(0x7fffffffffffffff), 1)); | 103 InRangeCast<int64_t>(INT64_C(0x7fffffffffffffff), 1)); | 
| 104 EXPECT_EQ(INT64_C(0x7fffffffffffffff), | |
| 105 InRangeCast<int64_t>(UINT64_C(0x7fffffffffffffff), 1)); | |
| 103 EXPECT_EQ(1, InRangeCast<int64_t>(UINT64_C(0x8000000000000000), 1)); | 106 EXPECT_EQ(1, InRangeCast<int64_t>(UINT64_C(0x8000000000000000), 1)); | 
| 104 EXPECT_EQ(1, InRangeCast<int64_t>(UINT64_C(0xffffffffffffffff), 1)); | 107 EXPECT_EQ(1, InRangeCast<int64_t>(UINT64_C(0xffffffffffffffff), 1)); | 
| 105 EXPECT_EQ(kInt32Min, InRangeCast<int64_t>(kInt32Min, 1)); | 108 EXPECT_EQ(kInt32Min, InRangeCast<int64_t>(kInt32Min, 1)); | 
| 106 EXPECT_EQ(kInt32Min, | 109 EXPECT_EQ(kInt32Min, | 
| 107 InRangeCast<int64_t>(implicit_cast<int64_t>(kInt32Min), 1)); | 110 InRangeCast<int64_t>(implicit_cast<int64_t>(kInt32Min), 1)); | 
| 111 EXPECT_EQ(kInt64Min, InRangeCast<int64_t>(kInt64Min, 1)); | |
| 108 EXPECT_EQ(0, InRangeCast<int64_t>(UINT64_C(0xffffffffffffffff), 0)); | 112 EXPECT_EQ(0, InRangeCast<int64_t>(UINT64_C(0xffffffffffffffff), 0)); | 
| 109 EXPECT_EQ(-1, InRangeCast<int64_t>(UINT64_C(0xffffffffffffffff), -1)); | 113 EXPECT_EQ(-1, InRangeCast<int64_t>(UINT64_C(0xffffffffffffffff), -1)); | 
| 110 EXPECT_EQ(kInt64Min, | 114 EXPECT_EQ(kInt64Min, | 
| 111 InRangeCast<int64_t>(UINT64_C(0xffffffffffffffff), kInt64Min)); | 115 InRangeCast<int64_t>(UINT64_C(0xffffffffffffffff), kInt64Min)); | 
| 112 EXPECT_EQ(INT64_C(0x7fffffffffffffff), | 116 EXPECT_EQ(INT64_C(0x7fffffffffffffff), | 
| 113 InRangeCast<int64_t>(UINT64_C(0xffffffffffffffff), | 117 InRangeCast<int64_t>(UINT64_C(0xffffffffffffffff), | 
| 114 INT64_C(0x7fffffffffffffff))); | 118 INT64_C(0x7fffffffffffffff))); | 
| 115 } | 119 } | 
| 116 | 120 | 
| 117 } // namespace | 121 } // namespace | 
| 118 } // namespace test | 122 } // namespace test | 
| 119 } // namespace crashpad | 123 } // namespace crashpad | 
| OLD | NEW |