Add ConnectToBestServices call when Certs are loaded

Add ConnectToBestServices call when Certs are loaded


BUG=137711
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191675

[stevenjb, 2013-03-27 21:37:54]

https://codereview.chromium.org/13004024/diff/1001/chromeos/dbus/shill_manage...
File chromeos/dbus/shill_manager_client.cc (right):

https://codereview.chromium.org/13004024/diff/1001/chromeos/dbus/shill_manage...
chromeos/dbus/shill_manager_client.cc:242: "ConnectToBestServices");
Note: this needs to be replaced with the shill constant once it (correctly)
makes it in (it was initially committed as "ConnectToBestService" not
"Services").

[stevenjb, 2013-03-27 23:02:34]

Hold off on this, turns out it's a bit trickier than I thought...

[stevenjb, 2013-03-28 01:51:13]

OK, this is correct now, except for adding the service constant.

https://codereview.chromium.org/13004024/diff/6001/chromeos/dbus/shill_manage...
File chromeos/dbus/shill_manager_client.cc (right):

https://codereview.chromium.org/13004024/diff/6001/chromeos/dbus/shill_manage...
chromeos/dbus/shill_manager_client.cc:242: "ConnectToBestServices");
Still TODO: Use Shill constant.

[stevenjb, 2013-03-28 18:25:33]

Gaurav / Philipp, can you take a look at this since Greg is OOO for the rest of
the week?

[Greg Spencer (Chromium), 2013-04-01 19:37:18]

LGTM

https://codereview.chromium.org/13004024/diff/25001/chrome/browser/chromeos/c...
File chrome/browser/chromeos/cros/cert_library.cc (right):

https://codereview.chromium.org/13004024/diff/25001/chrome/browser/chromeos/c...
chrome/browser/chromeos/cros/cert_library.cc:645: return token;
I'd almost like to see rot13 or something implemented here, just so we get
something similar to encryption, but I guess that's probably overkill.

https://codereview.chromium.org/13004024/diff/25001/chromeos/network/shill_pr...
File chromeos/network/shill_property_handler.h (right):

https://codereview.chromium.org/13004024/diff/25001/chromeos/network/shill_pr...
chromeos/network/shill_property_handler.h:42: public
base::SupportsWeakPtr<ShillPropertyHandler> {
Ooh, is that the new way to do weak pointer support?  Nice.

[stevenjb, 2013-04-01 20:34:48]

https://codereview.chromium.org/13004024/diff/25001/chrome/browser/chromeos/c...
File chrome/browser/chromeos/cros/cert_library.cc (right):

https://codereview.chromium.org/13004024/diff/25001/chrome/browser/chromeos/c...
chrome/browser/chromeos/cros/cert_library.cc:645: return token;
On 2013/04/01 19:37:18, Greg Spencer (Chromium) wrote:
> I'd almost like to see rot13 or something implemented here, just so we get
> something similar to encryption, but I guess that's probably overkill.

At some point I agree, along with some actual tests :) I actually would like to
see some significant re-factoring here also.

https://codereview.chromium.org/13004024/diff/25001/chromeos/network/shill_pr...
File chromeos/network/shill_property_handler.h (right):

https://codereview.chromium.org/13004024/diff/25001/chromeos/network/shill_pr...
chromeos/network/shill_property_handler.h:42: public
base::SupportsWeakPtr<ShillPropertyHandler> {
On 2013/04/01 19:37:18, Greg Spencer (Chromium) wrote:
> Ooh, is that the new way to do weak pointer support?  Nice.

It's not exactly new, I'm not sure why I usually use a member instead of
inheriting SupportsWeakPtr. This is definitely better though if another class
needs to access this as a weak ptr though.

[stevenjb, 2013-04-01 21:50:33]

Committed patchset #9 manually as r191675 (presubmit successful).