Add ConnectToBestServices call when Certs are loaded

chrome/browser/chromeos/cros/cert_library.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/cros/cert_library.h"
 
 #include <algorithm>
 
 #include "base/chromeos/chromeos_version.h"
 #include "base/command_line.h"
@@ skipping 581 matching lines @@
   CertList server_certs_;
   CertList server_ca_certs_;
 
   base::WeakPtrFactory<CertLibraryImpl> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(CertLibraryImpl);
 };
 
 //////////////////////////////////////////////////////////////////////////////
 
+class CertLibraryImplStub : public CertLibrary {
+ public:
+  CertLibraryImplStub()
+      : token_name_("StubToken"),
+        ALLOW_THIS_IN_INITIALIZER_LIST(cert_list_(this)) {
+  }
+  virtual ~CertLibraryImplStub() {}
+
+  virtual void AddObserver(Observer* observer) {}
+  virtual void RemoveObserver(Observer* observer) {}
+  virtual void LoadKeyStore() {}
+  virtual bool CertificatesLoading() const {
+    return false;
+  }
+  virtual bool CertificatesLoaded() const {
+    return true;
+  }
+  virtual bool IsHardwareBacked() const {
+    return false;
+  }
+  virtual const std::string& GetTpmTokenName() const {
+    return token_name_;
+  }
+  virtual const CertList& GetCertificates() const {
+    return cert_list_;
+  }
+  virtual const CertList& GetUserCertificates() const {
+    return cert_list_;
+  }
+  virtual const CertList& GetServerCertificates() const {
+    return cert_list_;
+  }
+  virtual const CertList& GetCACertificates() const {
+    return cert_list_;
+  }
+  virtual std::string EncryptWithSystemSalt(const std::string& token) {
+    return token;
+  }
+  virtual std::string DecryptWithSystemSalt(
+      const std::string& encrypted_token_hex) {
+    return encrypted_token_hex;
+  }
+  virtual std::string EncryptWithUserKey(const std::string& token) {
+    return token;

[Greg Spencer (Chromium), 2013/04/01 19:37:18]

I'd almost like to see rot13 or something implemented here, just so we get
something similar to encryption, but I guess that's probably overkill.

[stevenjb, 2013/04/01 20:34:48]

At some point I agree, along with some actual tests :) I actually would like to
see some significant re-factoring here also.

+  }
+  virtual std::string DecryptWithUserKey(
+      const std::string& encrypted_token_hex) {
+    return encrypted_token_hex;
+  }
+
+ private:
+  std::string token_name_;
+  CertList cert_list_;
+
+  DISALLOW_COPY_AND_ASSIGN(CertLibraryImplStub);
+};
+
+//////////////////////////////////////////////////////////////////////////////
+
 CertLibrary::~CertLibrary() {
 }
 
 // static
 CertLibrary* CertLibrary::GetImpl(bool stub) {
-  // |stub| is ignored since we have no stub of CertLibrary.
   // TODO(stevenjb): Disassociate CertLibrary from CrosLibrary entirely.
   // crbug.com/133752
+  if (stub)
+    return new CertLibraryImplStub();
   return new CertLibraryImpl();
 }
 
 //////////////////////////////////////////////////////////////////////////////
 
 CertLibrary::CertList::CertList(CertLibrary* library)
     : cert_library_(library) {
 }
 
 CertLibrary::CertList::~CertList() {}
@@ skipping 47 matching lines @@
     net::X509Certificate* cert = GetCertificateAt(index);
     net::X509Certificate::OSCertHandle cert_handle = cert->os_cert_handle();
     std::string id = x509_certificate_model::GetPkcs11Id(cert_handle);
     if (id == pkcs11_id)
       return index;
   }
   return -1;  // Not found.
 }
 
 }  // chromeos