Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1300123002: Use calloc to allocate data that will be uploaded to vertex/index buffers in Chrome (Closed)

Created:
5 years, 4 months ago by bsalomon
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use calloc to allocate data that will be uploaded to vertex/index buffers in Chrome BUG=chromium:454267 BUG=chromium:522315 Committed: https://skia.googlesource.com/skia/+/7dea7b7df14f327f4af32a83af52ee695b4ab1e0

Patch Set 1 #

Patch Set 2 : done #

Patch Set 3 : unyodaize ptr tests #

Total comments: 2

Patch Set 4 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -22 lines) Patch
M include/gpu/GrCaps.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/gpu/GrBufferAllocPool.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrBufferAllocPool.cpp View 1 2 3 13 chunks +34 lines, -19 lines 0 comments Download
M src/gpu/GrCaps.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLBufferImpl.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bsalomon
5 years, 4 months ago (2015-08-19 14:23:45 UTC) #3
egdaniel
lgtm w/ nit https://codereview.chromium.org/1300123002/diff/40001/src/gpu/GrBufferAllocPool.cpp File src/gpu/GrBufferAllocPool.cpp (right): https://codereview.chromium.org/1300123002/diff/40001/src/gpu/GrBufferAllocPool.cpp#newcode84 src/gpu/GrBufferAllocPool.cpp:84: is there still an extra \n ...
5 years, 4 months ago (2015-08-19 14:39:30 UTC) #4
bsalomon
https://codereview.chromium.org/1300123002/diff/40001/src/gpu/GrBufferAllocPool.cpp File src/gpu/GrBufferAllocPool.cpp (right): https://codereview.chromium.org/1300123002/diff/40001/src/gpu/GrBufferAllocPool.cpp#newcode84 src/gpu/GrBufferAllocPool.cpp:84: On 2015/08/19 14:39:30, egdaniel wrote: > is there still ...
5 years, 4 months ago (2015-08-19 14:49:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300123002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300123002/60001
5 years, 4 months ago (2015-08-19 14:50:24 UTC) #8
robertphillips
lgtm
5 years, 4 months ago (2015-08-19 15:21:22 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 15:26:53 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/7dea7b7df14f327f4af32a83af52ee695b4ab1e0

Powered by Google App Engine
This is Rietveld 408576698