Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1300103003: Refactor code for calculating background image geometry (Closed)

Created:
5 years, 4 months ago by davve
Modified:
5 years, 4 months ago
Reviewers:
pdr., fs, wangxianzhu
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, slimming-paint-reviews_chromium.org, blink-reviews-rendering, jchaffraix+rendering, blink-reviews-paint_chromium.org, dshwang
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Refactor code for calculating background image geometry Extract BoxPainter::calculateBackgroundImageGeometry implementation and related functions to the BackgroundImageGeometry class. This enables shrinking the API surface of BackgroundImageGeometry and eases further code health improvements. BUG=521481 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200850

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -318 lines) Patch
M Source/core/layout/LayoutBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/BackgroundImageGeometry.h View 3 chunks +20 lines, -27 lines 0 comments Download
M Source/core/paint/BackgroundImageGeometry.cpp View 2 chunks +300 lines, -0 lines 0 comments Download
M Source/core/paint/BoxPainter.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/paint/BoxPainter.cpp View 2 chunks +1 line, -287 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
davve
BoxPainter::calculateBackgroundImageGeometry wasn't very well attached to the rest of BoxPainter. Moving it out (along with ...
5 years, 4 months ago (2015-08-19 12:40:37 UTC) #2
fs
lgtm
5 years, 4 months ago (2015-08-19 13:22:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300103003/1
5 years, 4 months ago (2015-08-19 18:59:21 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 21:55:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200850

Powered by Google App Engine
This is Rietveld 408576698