Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: Source/core/events/CustomEvent.h

Issue 1300093003: [bindings] Make all CustomEvent.initCustomEvent arguments non-optional and remove custom binding. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/custom/V8CustomEventCustom.cpp ('k') | Source/core/events/CustomEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/events/CustomEvent.h
diff --git a/Source/core/events/CustomEvent.h b/Source/core/events/CustomEvent.h
index 5fa94c952c946bfc35f10707090e475fa4782103..82d5f357081a276ef90f0fac1c6cb51382693d19 100644
--- a/Source/core/events/CustomEvent.h
+++ b/Source/core/events/CustomEvent.h
@@ -49,6 +49,7 @@ public:
return adoptRefWillBeNoop(new CustomEvent(type, initializer));
}
+ void initCustomEvent(const AtomicString& type, bool canBubble, bool cancelable, const ScriptValue& detail);
void initCustomEvent(const AtomicString& type, bool canBubble, bool cancelable, PassRefPtr<SerializedScriptValue>);
const AtomicString& interfaceName() const override;
@@ -56,7 +57,6 @@ public:
SerializedScriptValue* serializedDetail() { return m_serializedDetail.get(); }
ScriptValue detail() const { return m_detail; }
- void setDetail(ScriptValue detail) { m_detail = detail; }
DECLARE_VIRTUAL_TRACE();
« no previous file with comments | « Source/bindings/core/v8/custom/V8CustomEventCustom.cpp ('k') | Source/core/events/CustomEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698