Source/bindings/core/v8/custom/V8CustomEventCustom.cpp - Issue 1300093003: [bindings] Make all CustomEvent.initCustomEvent arguments non-optional and remove custom binding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8CustomEventCustom.cpp

Issue 1300093003: [bindings] Make all CustomEvent.initCustomEvent arguments non-optional and remove custom binding. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/virtual/stable/animations-unprefixed/animation-events-unprefixed-04.html ('k') | Source/core/events/CustomEvent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/custom/V8CustomEventCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp b/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp

index a4ea5aa84d9c712b2d4aae8c478c4be709224b7c..6e03109b4f8e5f1a3376404d813e4ed6ed9e00af 100644

--- a/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp

@@ -73,20 +73,4 @@ void V8CustomEvent::detailAttributeGetterCustom(const v8::FunctionCallbackInfo<v

v8SetReturnValue(info, cacheState(info.GetIsolate(), info.Holder(), detail));

}

-void V8CustomEvent::initCustomEventMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)

- CustomEvent* event = V8CustomEvent::toImpl(info.Holder());

- TOSTRING_VOID(V8StringResource<>, typeArg, info[0]);

- bool canBubbleArg;

- bool cancelableArg;

- if (!v8Call(info[1]->BooleanValue(info.GetIsolate()->GetCurrentContext()), canBubbleArg)

- || !v8Call(info[2]->BooleanValue(info.GetIsolate()->GetCurrentContext()), cancelableArg))

- return;

- v8::Local<v8::Value> detailsArg = info[3];

- event->initEvent(typeArg, canBubbleArg, cancelableArg);

- event->setDetail(ScriptValue(ScriptState::current(info.GetIsolate()), detailsArg));

} // namespace blink