Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1300093003: [bindings] Make all CustomEvent.initCustomEvent arguments non-optional and remove custom binding. (Closed)

Created:
5 years, 4 months ago by vivekg_samsung
Modified:
5 years, 4 months ago
Reviewers:
haraken, tkent, vivekg
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-bindings_chromium.org, Inactive, Eric Willigers, rjwright, shans, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Make all CustomEvent.initCustomEvent arguments non-optional and remove custom binding. BUG=345519 R=haraken@chromium.org, tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200831

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -34 lines) Patch
M LayoutTests/animations/animation-events-prefixed-04.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/animations/animation-events-unprefixed-04.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/virtual/stable/animations-unprefixed/animation-events-prefixed-04.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/virtual/stable/animations-unprefixed/animation-events-unprefixed-04.html View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/custom/V8CustomEventCustom.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M Source/core/events/CustomEvent.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/events/CustomEvent.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/events/CustomEvent.idl View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
vivekg
PTAL, thanks.
5 years, 4 months ago (2015-08-19 10:40:22 UTC) #2
haraken
Just to confirm, but does the new behavior match other browsers?
5 years, 4 months ago (2015-08-19 10:50:50 UTC) #3
vivekg
On 2015/08/19 at 10:50:50, haraken wrote: > Just to confirm, but does the new behavior ...
5 years, 4 months ago (2015-08-19 11:01:23 UTC) #4
haraken
LGTM +tkent-san for API owner review.
5 years, 4 months ago (2015-08-19 11:03:56 UTC) #5
tkent
web-exposed change LGTM
5 years, 4 months ago (2015-08-19 12:01:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300093003/1
5 years, 4 months ago (2015-08-19 12:02:02 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/108890)
5 years, 4 months ago (2015-08-19 12:12:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300093003/1
5 years, 4 months ago (2015-08-19 12:16:37 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/108894)
5 years, 4 months ago (2015-08-19 12:27:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300093003/1
5 years, 4 months ago (2015-08-19 13:01:48 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/95252)
5 years, 4 months ago (2015-08-19 15:07:16 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300093003/1
5 years, 4 months ago (2015-08-19 15:10:06 UTC) #20
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 16:14:22 UTC) #21
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200831

Powered by Google App Engine
This is Rietveld 408576698