Issue 130003002: Handle loops in audio graph better for PannerNodes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 130003002: Handle loops in audio graph better for PannerNodes (Closed)

Created:
6 years, 11 months ago by Raymond Toy (Google)

Modified:
6 years, 11 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
blink-reviews, Raymond Toy

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Handle loops in audio graph better for PannerNodes When a PannerNode searches the graph for audio sources connected to the panner, prevent feedback loops from causing infinite loops. Create a hashmap to keep track of all visited nodes so we don't visit them more than once. A test is also added to ensure we don't infloop. BUG=331446 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164822

Patch Set 1 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+102 lines, -7 lines)			Patch
A	LayoutTests/webaudio/panner-loop.html	View	1 chunk	+83 lines, -0 lines	0 comments	Download
A +	LayoutTests/webaudio/panner-loop-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/modules/webaudio/PannerNode.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/modules/webaudio/PannerNode.cpp	View	3 chunks	+15 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Raymond Toy (Google)

On 2014/01/09 21:46:00, Ken Russell wrote: > lgtm Thanks!

6 years, 11 months ago (2014-01-09 22:49:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/130003002/30001

6 years, 11 months ago (2014-01-09 22:49:24 UTC) #4

Message was sent while issue was closed.

Change committed as 164822

Expand Messages | Collapse Messages