core/src/fxge/fontdata/chromefontdata/FoxitSans.c - Issue 1299963002: Extern in .cpp files is a code smell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxge/fontdata/chromefontdata/FoxitSans.c

Issue 1299963002: Extern in .cpp files is a code smell. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxge/fontdata/chromefontdata/FoxitSans.c

diff --git a/core/src/fxge/fontdata/chromefontdata/FoxitSans.c b/core/src/fxge/fontdata/chromefontdata/FoxitSans.c

index cd87d2b5bac0619d1e4ccb7f791b7c6fe9a9895c..48465fc6c58f79f8cda60b89087d277adeb5a717 100644

--- a/core/src/fxge/fontdata/chromefontdata/FoxitSans.c

+++ b/core/src/fxge/fontdata/chromefontdata/FoxitSans.c

@@ -4,6 +4,8 @@

+#include "chromefontdata.h"

const unsigned char g_FoxitSansFontData [15025] = {0x1,

0x0, 0x4, 0x2, 0x0, 0x1, 0x1, 0x1, 0xd,

0x43, 0x68, 0x72, 0x6f, 0x6d, 0x53, 0x61, 0x6e,