Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: BUILD.gn

Issue 1299963002: Extern in .cpp files is a code smell. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | core/include/fpdfapi/fpdf_parser.h » ('j') | core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index d3c092e4687701985d2ec02729d05c23c9d35b5a..665340b36e14c1a67d8b72003d6117393be377d6 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -323,6 +323,7 @@ static_library("fpdftext") {
"core/src/fpdftext/txtproc.h",
"core/src/fpdftext/unicodenormalization.cpp",
"core/src/fpdftext/unicodenormalizationdata.cpp",
+ "core/src/fpdftext/unicodenormalizationdata.h",
]
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [
@@ -476,6 +477,7 @@ static_library("fxge") {
"core/src/fxge/dib/fx_dib_engine.cpp",
"core/src/fxge/dib/fx_dib_main.cpp",
"core/src/fxge/dib/fx_dib_transform.cpp",
+ "core/src/fxge/fontdata/chromefontdata/chromefontdata.h",
"core/src/fxge/fontdata/chromefontdata/FoxitDingbats.c",
"core/src/fxge/fontdata/chromefontdata/FoxitFixed.c",
"core/src/fxge/fontdata/chromefontdata/FoxitFixedBold.c",
« no previous file with comments | « no previous file | core/include/fpdfapi/fpdf_parser.h » ('j') | core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698