Issue 1299903002: Reland of Call dispatcher's releaseRegistration when done with registrations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1299903002: Reland of Call dispatcher's releaseRegistration when done with registrations (Closed)

Created:
5 years, 4 months ago by jkarlin

Modified:
5 years, 4 months ago

Reviewers:
jsbell

CC:
blink-reviews, dglazkov+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Reland of Call dispatcher's releaseRegistration when done with registrations This is a reland of https://codereview.chromium.org/1290073003/ Reproduced crash locally, https://codereview.chromium.org/1302543002/ fixes it. So after that lands land this again. TBR=jsbell@chromium.org BUG=502214 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200749

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -0 lines)			Patch
M	Source/modules/background_sync/PeriodicSyncRegistration.cpp	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	Source/modules/background_sync/SyncRegistration.cpp	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	public/platform/modules/background_sync/WebSyncProvider.h	View	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299903002/1

5 years, 4 months ago (2015-08-18 17:52:01 UTC) #4

commit-bot: I haz the power

5 years, 4 months ago (2015-08-18 19:58:55 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200749

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages