Source/modules/background_sync/SyncRegistration.cpp - Issue 1299903002: Reland of Call dispatcher's releaseRegistration when done with registrations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/background_sync/SyncRegistration.cpp

Issue 1299903002: Reland of Call dispatcher's releaseRegistration when done with registrations (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/background_sync/PeriodicSyncRegistration.cpp ('k') | public/platform/modules/background_sync/WebSyncProvider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/background_sync/SyncRegistration.cpp

diff --git a/Source/modules/background_sync/SyncRegistration.cpp b/Source/modules/background_sync/SyncRegistration.cpp

index 00783683f8245ffcb02b5fba2319c89df8b53fe6..64850cfa2435ec05ad3eccf30a4f1aa092d3a56a 100644

--- a/Source/modules/background_sync/SyncRegistration.cpp

+++ b/Source/modules/background_sync/SyncRegistration.cpp

@@ -48,6 +48,13 @@ SyncRegistration::SyncRegistration(int64_t id, const SyncRegistrationOptions& op

SyncRegistration::~SyncRegistration()

{

+ Platform* currentPlatform = Platform::current();

+ if (!currentPlatform)

+ return;

+ WebSyncProvider* syncProvider = currentPlatform->backgroundSyncProvider();

+ if (!syncProvider)

+ return;

+ syncProvider->releaseRegistration(m_id);

}

ScriptPromise SyncRegistration::done(ScriptState* scriptState)