Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1299873002: ALL-IN-ONE Introduce enum class TextAffinity (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
CC:
blink-reviews, szager+layoutwatch_chromium.org, eae+blinkwatch, fs, dcheng, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, krit, aboxhall, blink-reviews-html_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, je_julie, jchaffraix+rendering, gyuyoung2, rwlbuis, zoltan1, sof, dmazzoni, blink-reviews-rendering, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, nektarios, f(malita), groby+blinkspell_chromium.org, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

We should get rid of default TextAffinity parameter of VisiblePosition and VisibleSelection ctor before this patch. BUG=

Patch Set 1 #

Patch Set 2 : 2015-08-19T15:24:55 #

Patch Set 3 : 2015-08-19T16:25:26 #

Patch Set 4 : 2015-08-19T18:08:52 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -146 lines) Patch
M Source/core/dom/Element.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/DOMSelection.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/EditingUtilities.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/EditingUtilities.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/Editor.cpp View 1 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/FrameSelection.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 2 3 6 chunks +7 lines, -6 lines 0 comments Download
M Source/core/editing/InputMethodController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/Position.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/Position.cpp View 1 2 5 chunks +7 lines, -6 lines 0 comments Download
M Source/core/editing/PositionWithAffinity.h View 2 chunks +5 lines, -3 lines 0 comments Download
M Source/core/editing/PositionWithAffinity.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/RenderedPosition.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/editing/RenderedPosition.cpp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/TextAffinity.h View 1 chunk +4 lines, -6 lines 0 comments Download
M Source/core/editing/VisiblePosition.h View 1 2 3 5 chunks +8 lines, -7 lines 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 1 2 3 4 chunks +16 lines, -12 lines 0 comments Download
M Source/core/editing/VisibleSelection.h View 6 chunks +16 lines, -15 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 1 7 chunks +9 lines, -9 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 2 3 6 chunks +7 lines, -6 lines 0 comments Download
M Source/core/editing/VisibleUnitsTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/commands/ApplyBlockElementCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/commands/BreakBlockquoteCommand.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/commands/CompositeEditCommand.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/commands/CreateLinkCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/commands/DeleteSelectionCommand.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/commands/EditorCommand.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/commands/IndentOutdentCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/commands/InsertLineBreakCommand.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/commands/TypingCommand.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/spellcheck/SpellChecker.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextFormControlElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutBlock.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutObject.h View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutText.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutTreeAsText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/PendingSelection.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/PendingSelection.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGInlineText.cpp View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/accessibility/AXLayoutObject.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698