Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: Source/core/editing/PositionWithAffinity.h

Issue 1299873002: ALL-IN-ONE Introduce enum class TextAffinity (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-19T18:08:52 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/Position.cpp ('k') | Source/core/editing/PositionWithAffinity.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/PositionWithAffinity.h
diff --git a/Source/core/editing/PositionWithAffinity.h b/Source/core/editing/PositionWithAffinity.h
index 34d2970cf05a89e52d07715acdb29e3a8629e517..22c2e362650e59e8da1799d89d4c2366dab08e09 100644
--- a/Source/core/editing/PositionWithAffinity.h
+++ b/Source/core/editing/PositionWithAffinity.h
@@ -15,11 +15,13 @@ template <typename Strategy>
class CORE_TEMPLATE_CLASS_EXPORT PositionWithAffinityTemplate {
DISALLOW_ALLOCATION();
public:
- PositionWithAffinityTemplate(const PositionAlgorithm<Strategy>&, EAffinity = DOWNSTREAM);
+ // TODO(yosin) We should have single parameter constructor not to use
+ // default parameter for avoiding include "TextAffinity.h"
+ PositionWithAffinityTemplate(const PositionAlgorithm<Strategy>&, TextAffinity = TextAffinity::Downstream);
PositionWithAffinityTemplate();
~PositionWithAffinityTemplate();
- EAffinity affinity() const { return m_affinity; }
+ TextAffinity affinity() const { return m_affinity; }
const PositionAlgorithm<Strategy>& position() const { return m_position; }
// Returns true if both |this| and |other| is null or both |m_position|
@@ -37,7 +39,7 @@ public:
private:
PositionAlgorithm<Strategy> m_position;
- EAffinity m_affinity;
+ TextAffinity m_affinity;
};
extern template class CORE_EXTERN_TEMPLATE_EXPORT PositionWithAffinityTemplate<EditingStrategy>;
« no previous file with comments | « Source/core/editing/Position.cpp ('k') | Source/core/editing/PositionWithAffinity.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698