Issue 12998005: Minor cleanups for user experiments (follow-up to Issue 12321061).

Issue 12998005: Minor cleanups for user experiments (follow-up to Issue 12321061). (Closed)

Created:
7 years, 9 months ago by huangs

Modified:
7 years, 9 months ago

Reviewers:
gab, grt (UTC plus 2)

CC:
chromium-reviews, grt+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Minor cleanups for user experiments (follow-up to Issue 12321061). BUG=170398 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191005

Patch Set 2 : Comment fix. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
M	chrome/installer/setup/setup_main.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/installer/util/user_experiment.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/user_experiment.cc	View		4 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

huangs

Follow up to https://codereview.chromium.org/12805010/ This handles the easy stuff; will do the more challenge work ...

7 years, 9 months ago (2013-03-26 20:24:24 UTC) #1

grt (UTC plus 2)

https://codereview.chromium.org/12998005/diff/1/chrome/installer/setup/setup_main.cc File chrome/installer/setup/setup_main.cc (right): https://codereview.chromium.org/12998005/diff/1/chrome/installer/setup/setup_main.cc#newcode1428 chrome/installer/setup/setup_main.cc:1428: // This code is called (via Chrome relaunch) only ...

7 years, 9 months ago (2013-03-27 13:49:23 UTC) #2

huangs

PTAL. https://codereview.chromium.org/12998005/diff/1/chrome/installer/setup/setup_main.cc File chrome/installer/setup/setup_main.cc (right): https://codereview.chromium.org/12998005/diff/1/chrome/installer/setup/setup_main.cc#newcode1428 chrome/installer/setup/setup_main.cc:1428: // This code is called (via Chrome relaunch) ...

7 years, 9 months ago (2013-03-27 15:01:25 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/huangs@chromium.org/12998005/5001

7 years, 9 months ago (2013-03-27 17:48:46 UTC) #6

Message was sent while issue was closed.

Change committed as 191005

Expand Messages | Collapse Messages