chrome/installer/setup/setup_main.cc - Issue 12998005: Minor cleanups for user experiments (follow-up to Issue 12321061).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/setup_main.cc

Issue 12998005: Minor cleanups for user experiments (follow-up to Issue 12321061). (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Comment fix. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/setup/setup_main.cc

diff --git a/chrome/installer/setup/setup_main.cc b/chrome/installer/setup/setup_main.cc

index 0cf8f84389044d26883a7e05611ecbaa36f958b7..fd1b561543bf7493d5b2b567111ed2834776677e 100644

--- a/chrome/installer/setup/setup_main.cc

+++ b/chrome/installer/setup/setup_main.cc

@@ -1425,6 +1425,8 @@ bool HandleNonInstallCmdLineOptions(const InstallationState& original_state,

if (flavor == -1) {

*exit_code = installer::UNKNOWN_STATUS;

} else {

+ // This code is called (via setup.exe relaunch) only if a product is known

+ // to run user experiments, so no check is required.

const Products& products = installer_state->products();

for (Products::const_iterator it = products.begin(); it < products.end();

++it) {

« no previous file with comments | « no previous file | chrome/installer/util/user_experiment.h » ('j') | no next file with comments »