Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1299703003: Stop ping ponging AA in SkGpuDevice (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Stop ping ponging AA in SkGpuDevice BUG=skia: Committed: https://skia.googlesource.com/skia/+/1a899c9d547e5f12505e5bf654e4fb8b7dda0669

Patch Set 1 #

Total comments: 1

Patch Set 2 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -27 lines) Patch
M src/gpu/SkGpuDevice.cpp View 1 1 chunk +5 lines, -27 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
joshualitt
5 years, 4 months ago (2015-08-17 18:10:11 UTC) #2
robertphillips
lgtm + question https://codereview.chromium.org/1299703003/diff/1/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (left): https://codereview.chromium.org/1299703003/diff/1/src/gpu/SkGpuDevice.cpp#oldcode1034 src/gpu/SkGpuDevice.cpp:1034: int maxTextureSize = fContext->caps()->maxTextureSize(); Should 'directDraw' ...
5 years, 4 months ago (2015-08-17 18:17:07 UTC) #3
joshualitt
Robert, could you take a quick look at my inversion of the boolean? I think ...
5 years, 4 months ago (2015-08-17 18:45:10 UTC) #4
robertphillips
lgtm
5 years, 4 months ago (2015-08-17 18:46:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299703003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299703003/20001
5 years, 4 months ago (2015-08-17 18:47:31 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 18:53:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1a899c9d547e5f12505e5bf654e4fb8b7dda0669

Powered by Google App Engine
This is Rietveld 408576698