HTMLImageElement width/height should updateLayout first.

HTMLImageElement width/height should updateLayout first.

HTMLImageElement::width/height were not updating layout first before
checking for the layoutObject() which means that we fall back to the
attribute when we shouldn't. We're also using the updateLayout method
instead of updateLayoutIgnorePendingStylesheets which should be used
for all JS APIs. Finally I deleted the unused boolean argument to the
methods.

We also make sure to check if we're in the document before causing a
layout so checking for a disconnected image's width/height before
drawing to a canvas doesn't cause a sync layout.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200594

[esprehn, 2015-08-15 01:57:04]

esprehn@chromium.org changed reviewers:
+ dglazkov@chromium.org, ojan@chromium.org, pdr@chromium.org

[esprehn, 2015-08-15 01:57:17]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-15 01:57:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1299563002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1299563002/20001

[esprehn, 2015-08-15 02:01:31]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-15 02:01:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1299563002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1299563002/40001

[pdr., 2015-08-15 02:09:26]

LGTM with a question

https://codereview.chromium.org/1299563002/diff/40001/Source/core/html/HTMLIm...
File Source/core/html/HTMLImageElement.cpp (right):

https://codereview.chromium.org/1299563002/diff/40001/Source/core/html/HTMLIm...
Source/core/html/HTMLImageElement.cpp:425: if (inActiveDocument())
The inActiveDocument check seems like a good idea. This doesn't seem to be
checked in other updateLayoutIngorePendingStylesheets calls--are those bugs or
is there a reason this is only needed here?

[esprehn, 2015-08-15 02:16:36]

On 2015/08/15 at 02:09:26, pdr wrote:
> LGTM with a question
> 
>
https://codereview.chromium.org/1299563002/diff/40001/Source/core/html/HTMLIm...
> File Source/core/html/HTMLImageElement.cpp (right):
> 
>
https://codereview.chromium.org/1299563002/diff/40001/Source/core/html/HTMLIm...
> Source/core/html/HTMLImageElement.cpp:425: if (inActiveDocument())
> The inActiveDocument check seems like a good idea. This doesn't seem to be
checked in other updateLayoutIngorePendingStylesheets calls--are those bugs or
is there a reason this is only needed here?

They should check too, I'm fixing that here:
https://codereview.chromium.org/1285393003

[pdr., 2015-08-15 02:24:38]

On 2015/08/15 at 02:16:36, esprehn wrote:
> On 2015/08/15 at 02:09:26, pdr wrote:
> > LGTM with a question
> > 
> >
https://codereview.chromium.org/1299563002/diff/40001/Source/core/html/HTMLIm...
> > File Source/core/html/HTMLImageElement.cpp (right):
> > 
> >
https://codereview.chromium.org/1299563002/diff/40001/Source/core/html/HTMLIm...
> > Source/core/html/HTMLImageElement.cpp:425: if (inActiveDocument())
> > The inActiveDocument check seems like a good idea. This doesn't seem to be
checked in other updateLayoutIngorePendingStylesheets calls--are those bugs or
is there a reason this is only needed here?
> 
> They should check too, I'm fixing that here:
> https://codereview.chromium.org/1285393003

Thanks, LGTM.

[commit-bot: I haz the power, 2015-08-15 03:36:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-15 03:36:49]

Dry run: This issue passed the CQ dry run.

[esprehn, 2015-08-15 03:49:03]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2015-08-15 03:49:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1299563002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1299563002/40001

[commit-bot: I haz the power, 2015-08-15 03:53:50]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200594