Element should check inActiveDocument before forcing layout.

Element should check inActiveDocument before forcing layout.

We would force layouts when touching layout sensitive properties on
disconnected elements which is bad, for example:

div = document.createElement('div')
div.offsetTop; // force layout for no reason. :(

Instead lets always check first. There's still other places in the
codebase to check, but lets start with Element.

BUG=585663

[esprehn, 2015-08-15 02:16:51]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[esprehn, 2015-08-15 02:17:16]

esprehn@chromium.org changed reviewers:
+ dglazkov@chromium.org, ojan@chromium.org, pdr@chromium.org

[esprehn, 2015-08-15 02:17:16]

This probably needs a test, so many functions to test...

[commit-bot: I haz the power, 2015-08-15 02:17:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1285393003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1285393003/1

[pdr., 2015-08-15 02:29:16]

Can we fix this higher up such as in the bindings layer? It's too easy to
re-introduce this bug.

Can you ASSERT(inActiveDocument()); in updateLayoutIgnorePendingStylesheets too?

[commit-bot: I haz the power, 2015-08-15 02:43:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-15 02:43:38]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[esprehn, 2016-02-10 00:51:07]

Description was changed from

==========
Element should check inActiveDocument before forcing layout.

We would force layouts when touching layout sensitive properties on
disconnected elements which is bad, for example:

div = document.createElement('div')
div.offsetTop; // force layout for no reason. :(

Instead lets always check first. There's still other places in the
codebase to check, but lets start with Element.
==========

to

==========
Element should check inActiveDocument before forcing layout.

We would force layouts when touching layout sensitive properties on
disconnected elements which is bad, for example:

div = document.createElement('div')
div.offsetTop; // force layout for no reason. :(

Instead lets always check first. There's still other places in the
codebase to check, but lets start with Element.

BUG=585663
==========