Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 1299503002: Sandbox: Reenable test that was flaking for being too slow. (Closed)

Created:
5 years, 4 months ago by rvargas (doing something else)
Modified:
5 years, 4 months ago
Reviewers:
jschuh
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sandbox: Reenable test that was flaking for being too slow. The timeouts were increased long time ago so presumably this test should not fail anymore. There is no information about why UnloadAviCapDllWithPatching was flaky, but I'm assuming the same cause of the other two unload tests. BUG=38404, 137652 Committed: https://crrev.com/1cab7911d131799caf704a276b3cac29b1dc8fb3 Cr-Commit-Position: refs/heads/master@{#343501}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M sandbox/win/src/unload_dll_test.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rvargas (doing something else)
PTAL
5 years, 4 months ago (2015-08-14 20:07:00 UTC) #2
jschuh
lgtm
5 years, 4 months ago (2015-08-14 21:14:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299503002/1
5 years, 4 months ago (2015-08-14 21:37:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-14 21:42:36 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 21:43:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1cab7911d131799caf704a276b3cac29b1dc8fb3
Cr-Commit-Position: refs/heads/master@{#343501}

Powered by Google App Engine
This is Rietveld 408576698