sandbox/win/src/unload_dll_test.cc - Issue 1299503002: Sandbox: Reenable test that was flaking for being too slow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/win/src/unload_dll_test.cc

Issue 1299503002: Sandbox: Reenable test that was flaking for being too slow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sandbox/win/src/unload_dll_test.cc

diff --git a/sandbox/win/src/unload_dll_test.cc b/sandbox/win/src/unload_dll_test.cc

index 620016c6bd8bbfb1eaad2f1fa8fb4e8e57f15167..89c4dfce592258efcf453ea63720ca8162cd98c0 100644

--- a/sandbox/win/src/unload_dll_test.cc

+++ b/sandbox/win/src/unload_dll_test.cc

@@ -67,8 +67,7 @@ TEST(UnloadDllTest, DISABLED_UnloadAviCapDllNoPatching) {

EXPECT_EQ(SBOX_TEST_FAILED, runner.RunTest(L"UseOneDLL B avicap32.dll"));

}

-// Flaky: http://crbug.com/38404

-TEST(UnloadDllTest, DISABLED_UnloadAviCapDllWithPatching) {

+TEST(UnloadDllTest, UnloadAviCapDllWithPatching) {

TestRunner runner;

runner.SetTimeout(2000);

runner.SetTestState(BEFORE_REVERT);

« no previous file with comments | « no previous file | no next file » | no next file with comments »