Issue 1299323006: [Editing][CodeHealth] Move Position::up/downstream implementation to VisibleUnit.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1299323006: [Editing][CodeHealth] Move Position::up/downstream implementation to VisibleUnit.cpp (Closed)

Created:
5 years, 4 months ago by yoichio

Modified:
5 years, 4 months ago

Reviewers:
yosin_UTC9

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

[Editing][CodeHealth] Move Position::up/downstream implementation to VisibleUnit.cpp Moved Position::up/downstream implementation to VisibleUnit.cpp and renamed mostForwardCaretPosition/mostBackwardCaretPosition. This CL splits Position implementation from layout object. Position::upstream just calls mostForwardCaretPosition but the callers will call it directly. BUG=518738 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200884

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+331 lines, -287 lines)			Patch
M	Source/core/editing/Position.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/editing/Position.cpp	View	1 chunk	+2 lines, -287 lines	0 comments	Download
M	Source/core/editing/VisibleUnits.h	View	1 chunk	+23 lines, -0 lines	0 comments	Download
M	Source/core/editing/VisibleUnits.cpp	View	2 chunks	+305 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299323006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299323006/1

5 years, 4 months ago (2015-08-20 07:32:35 UTC) #5

commit-bot: I haz the power

5 years, 4 months ago (2015-08-20 08:21:10 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200884

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages