Source/core/editing/Position.h - Issue 1299323006: [Editing][CodeHealth] Move Position::up/downstream implementation to VisibleUnit.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/Position.h

Issue 1299323006: [Editing][CodeHealth] Move Position::up/downstream implementation to VisibleUnit.cpp (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/Position.h

diff --git a/Source/core/editing/Position.h b/Source/core/editing/Position.h

index d0f15997a9c45d9c9d219690e0b1e3e896f3b871..c8401e1dda0b0662a8d80837efaed6af80dfae46 100644

--- a/Source/core/editing/Position.h

+++ b/Source/core/editing/Position.h

@@ -186,6 +186,7 @@ public:

bool atEndOfTree() const;

// These return useful visually equivalent positions.

+ // FIXME: We should use mostForwardCaretPosition and mostBackwardPosition.

PositionAlgorithm<Strategy> upstream(EditingBoundaryCrossingRule = CannotCrossEditingBoundary) const;

PositionAlgorithm<Strategy> downstream(EditingBoundaryCrossingRule = CannotCrossEditingBoundary) const;

« no previous file with comments | « no previous file | Source/core/editing/Position.cpp » ('j') | no next file with comments »