Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1409)

Issue 1299003003: [GN] Don't hardcode google_play_services dependencies (Closed)

Created:
5 years, 4 months ago by dgn
Modified:
5 years, 4 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GN] Don't hardcode google_play_services dependencies There is a google_play_services_library variable that should be used instead of hardcoding the java target. Added another such variable for resources BUG=521624 Committed: https://crrev.com/6cd230bdd3ebabff123c44e01ef0384fa1ac1b2b Cr-Commit-Position: refs/heads/master@{#344183}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M build/config/android/config.gni View 1 chunk +5 lines, -0 lines 0 comments Download
M build/secondary/third_party/android_tools/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/app/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
dgn
dpranke@chromium.org: Please review changes in //build/ bauerb@chromium.org: Please review changes in //chrome/android
5 years, 4 months ago (2015-08-18 17:28:45 UTC) #2
Dirk Pranke
lgtm
5 years, 4 months ago (2015-08-18 19:01:54 UTC) #3
dgn
Thanks! sky@: PTAL at the changes in //mojo and //mandoline
5 years, 4 months ago (2015-08-18 21:09:06 UTC) #4
dgn
Thanks! sky@: PTAL at the changes in //mojo and //mandoline
5 years, 4 months ago (2015-08-18 21:09:09 UTC) #5
dgn
sky@chromium.org: Please review changes in //mojo and //mandoline
5 years, 4 months ago (2015-08-18 21:10:17 UTC) #7
sky
LGTM
5 years, 4 months ago (2015-08-18 22:38:46 UTC) #8
Bernhard Bauer
lgtm
5 years, 4 months ago (2015-08-19 08:08:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299003003/1
5 years, 4 months ago (2015-08-19 08:46:41 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-19 08:53:07 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 08:53:38 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6cd230bdd3ebabff123c44e01ef0384fa1ac1b2b
Cr-Commit-Position: refs/heads/master@{#344183}

Powered by Google App Engine
This is Rietveld 408576698