build/secondary/third_party/android_tools/BUILD.gn - Issue 1299003003: [GN] Don't hardcode google_play_services dependencies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/secondary/third_party/android_tools/BUILD.gn

Issue 1299003003: [GN] Don't hardcode google_play_services dependencies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/secondary/third_party/android_tools/BUILD.gn

diff --git a/build/secondary/third_party/android_tools/BUILD.gn b/build/secondary/third_party/android_tools/BUILD.gn

index 977a6044117fa9c582a7f32873de78c6efe8401e..06503b3c4afee1693c5cf9c9886cf591240a7533 100644

--- a/build/secondary/third_party/android_tools/BUILD.gn

+++ b/build/secondary/third_party/android_tools/BUILD.gn

@@ -105,6 +105,9 @@ android_resources("google_play_services_default_resources") {

v14_skip = true

resource_dirs = [ "$android_sdk_root/extras/google/google_play_services/libproject/google-play-services_lib/res" ]

custom_package = "com.google.android.gms"

+ deps = [

+ ":check_sdk_extras_version",

+ ]

}

android_java_prebuilt("google_play_services_default_java") {

deps = [

« no previous file with comments | « build/config/android/config.gni ('k') | chrome/android/BUILD.gn » ('j') | no next file with comments »