Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 1298973007: Stop prepending "r" to commit hashes in merge_to_branch.py (Closed)

Created:
5 years, 4 months ago by adamk
Modified:
5 years, 3 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Stop prepending "r" to commit hashes in merge_to_branch.py R=machenbach@chromium.org Committed: https://crrev.com/e5dbfd06c3dab5934e846c40af2a8b7fb5cdf0d6 Cr-Commit-Position: refs/heads/master@{#30483}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M tools/release/merge_to_branch.py View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
adamk
5 years, 4 months ago (2015-08-19 20:42:05 UTC) #1
Michael Achenbach
lgtm - note that this string is just used for printing in the end. It ...
5 years, 3 months ago (2015-08-31 11:54:08 UTC) #2
adamk
On 2015/08/31 11:54:08, Michael Achenbach wrote: > lgtm - note that this string is just ...
5 years, 3 months ago (2015-08-31 17:23:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298973007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298973007/1
5 years, 3 months ago (2015-08-31 17:23:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-31 17:46:17 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e5dbfd06c3dab5934e846c40af2a8b7fb5cdf0d6 Cr-Commit-Position: refs/heads/master@{#30483}
5 years, 3 months ago (2015-08-31 17:46:41 UTC) #7
Michael Hablich
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1321343002/ by hablich@chromium.org. ...
5 years, 3 months ago (2015-09-01 11:10:53 UTC) #8
adamk
5 years, 3 months ago (2015-09-01 15:50:22 UTC) #9
Message was sent while issue was closed.
lgtm, thanks for the fix (and sorry for the breakage). Python is just not my
thing...

Powered by Google App Engine
This is Rietveld 408576698