tools/release/merge_to_branch.py - Issue 1298973007: Stop prepending "r" to commit hashes in merge_to_branch.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/release/merge_to_branch.py

Issue 1298973007: Stop prepending "r" to commit hashes in merge_to_branch.py (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/release/merge_to_branch.py

diff --git a/tools/release/merge_to_branch.py b/tools/release/merge_to_branch.py

index 5fe3ba42516ea9b6004ee925e3a0bae8e3ebd005..7950fbda345bf8768c9b3ab11474079ad9fa1dc9 100755

--- a/tools/release/merge_to_branch.py

+++ b/tools/release/merge_to_branch.py

@@ -104,9 +104,8 @@ class CreateCommitMessage(Step):

def RunStep(self):

- # Stringify: [123, 234] -> "r123, r234"

- self["revision_list"] = ", ".join(map(lambda s: "r%s" % s,

- self["full_revision_list"]))

+ # Stringify: ["abcde", "12345"] -> "abcde, 12345"

+ self["revision_list"] = ", ".join(self["full_revision_list"]))

if not self["revision_list"]: # pragma: no cover

self.Die("Revision list is empty.")

« no previous file with comments | « no previous file | no next file » | no next file with comments »