[SPDY] Remove some setters in SpdyStream

net/spdy/spdy_session.h

Index: net/spdy/spdy_session.h
diff --git a/net/spdy/spdy_session.h b/net/spdy/spdy_session.h
index 8451bb37268099d0e7dc09c5f8e926505f711688..0d52b905bbac1406a05e0f660f82576170cb8cdc 100644
--- a/net/spdy/spdy_session.h
+++ b/net/spdy/spdy_session.h
@@ -198,9 +198,6 @@ class NET_EXPORT SpdySession : public base::RefCounted<SpdySession>,
     static SpdyIOBuffer* CreateIOBuffer(SpdyFrame* frame,
                                         RequestPriority priority,
                                         SpdyStream* spdy_stream);
-
-   private:
-    DISALLOW_COPY_AND_ASSIGN(SpdyIOBufferProducer);

[Ryan Hamilton, 2013/03/24 15:08:40]

How come this needs to be removed?

[akalin, 2013/03/24 19:24:53]

It doesn't have to, but on the other hand it doesn't make sense. One cannot
instantiate a SpdyIOBufferProducer by itself since it's abstract, so there would
be no occasion for the copy/assign to happen with it.

The only thing this prevents is subclass instances being copyable/assignable,
but that seems like something that's best left for individual subclasses to
decide.

[Ryan Hamilton, 2013/03/25 17:07:47]

But the style guide says to only allow copy constructors when they're required,
otherwise disallow them.  To me, this says to use the macro unless we *NEED* the
copy construction behavior.  Since we don't need it it this case, it seems like
the style guide requires in.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Copy_C...

[akalin, 2013/03/25 19:24:48]

Hmm you're right. Okay, put it back in.

   };
 
   // Create a new SpdySession.