[SPDY] Remove some setters in SpdyStream

net/spdy/spdy_session.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SPDY_SPDY_SESSION_H_
 #define NET_SPDY_SPDY_SESSION_H_
 
 #include <deque>
 #include <list>
 #include <map>
@@ skipping 180 matching lines @@
     virtual ~SpdyIOBufferProducer() {}
 
    protected:
     // Activates |spdy_stream| in |spdy_session|.
     static void ActivateStream(SpdySession* spdy_session,
                                SpdyStream* spdy_stream);
 
     static SpdyIOBuffer* CreateIOBuffer(SpdyFrame* frame,
                                         RequestPriority priority,
                                         SpdyStream* spdy_stream);
-
-   private:
-    DISALLOW_COPY_AND_ASSIGN(SpdyIOBufferProducer);

[Ryan Hamilton, 2013/03/24 15:08:40]

How come this needs to be removed?

[akalin, 2013/03/24 19:24:53]

It doesn't have to, but on the other hand it doesn't make sense. One cannot
instantiate a SpdyIOBufferProducer by itself since it's abstract, so there would
be no occasion for the copy/assign to happen with it.

The only thing this prevents is subclass instances being copyable/assignable,
but that seems like something that's best left for individual subclasses to
decide.

[Ryan Hamilton, 2013/03/25 17:07:47]

But the style guide says to only allow copy constructors when they're required,
otherwise disallow them.  To me, this says to use the macro unless we *NEED* the
copy construction behavior.  Since we don't need it it this case, it seems like
the style guide requires in.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Copy_C...

[akalin, 2013/03/25 19:24:48]

Hmm you're right. Okay, put it back in.

   };
 
   // Create a new SpdySession.
   // |host_port_proxy_pair| is the host/port that this session connects to, and
   // the proxy configuration settings that it's using.
   // |spdy_session_pool| is the SpdySessionPool that owns us.  Its lifetime must
   // strictly be greater than |this|.
   // |session| is the HttpNetworkSession.  |net_log| is the NetLog that we log
   // network events to.
   SpdySession(const HostPortProxyPair& host_port_proxy_pair,
@@ skipping 692 matching lines @@
   // This SPDY proxy is allowed to push resources from origins that are
   // different from those of their associated streams.
   HostPortPair trusted_spdy_proxy_;
 
   TimeFunc time_func_;
 };
 
 }  // namespace net
 
 #endif  // NET_SPDY_SPDY_SESSION_H_