Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 1298683002: Convert components/tracing from static lib to component (Closed)

Created:
5 years, 4 months ago by Ruud van Asseldonk
Modified:
5 years, 4 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert components/tracing from static lib to component This is a prerequisite for https://crrev.com/1292583002. BUG=518823 Committed: https://crrev.com/da965e85fdb2008392c3d313a04a67f8e794ddad Cr-Commit-Position: refs/heads/master@{#343700}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -5 lines) Patch
M components/tracing.gyp View 2 chunks +5 lines, -1 line 0 comments Download
M components/tracing/BUILD.gn View 1 chunk +8 lines, -2 lines 0 comments Download
M components/tracing/child_trace_message_filter.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/tracing/startup_tracing.h View 1 chunk +3 lines, -1 line 0 comments Download
A components/tracing/tracing_export.h View 1 chunk +29 lines, -0 lines 0 comments Download
M components/tracing/tracing_messages.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
Ruud van Asseldonk
5 years, 4 months ago (2015-08-17 13:09:40 UTC) #2
dsinclair
lgtm
5 years, 4 months ago (2015-08-17 13:39:07 UTC) #3
Primiano Tucci (use gerrit)
LGTM with 1 minor comment. Many thanks for doing this. https://codereview.chromium.org/1298683002/diff/1/components/BUILD.gn File components/BUILD.gn (right): https://codereview.chromium.org/1298683002/diff/1/components/BUILD.gn#newcode467 ...
5 years, 4 months ago (2015-08-17 13:51:21 UTC) #4
Ruud van Asseldonk
https://codereview.chromium.org/1298683002/diff/1/components/BUILD.gn File components/BUILD.gn (right): https://codereview.chromium.org/1298683002/diff/1/components/BUILD.gn#newcode467 components/BUILD.gn:467: "//components/tracing", On 2015/08/17 13:51:21, Primiano Tucci wrote: > I'd ...
5 years, 4 months ago (2015-08-17 14:58:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298683002/20001
5 years, 4 months ago (2015-08-17 14:59:40 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/88855)
5 years, 4 months ago (2015-08-17 15:14:41 UTC) #10
Ruud van Asseldonk
+dcheng: for owner stamp tracing_messages.h Can you please take a look at three-line change? This ...
5 years, 4 months ago (2015-08-17 15:32:36 UTC) #12
blundell
//components lgtm
5 years, 4 months ago (2015-08-17 15:35:52 UTC) #14
dcheng
IPC changes LGTM
5 years, 4 months ago (2015-08-17 16:20:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298683002/20001
5 years, 4 months ago (2015-08-17 16:24:21 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-17 17:02:06 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 17:02:47 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/da965e85fdb2008392c3d313a04a67f8e794ddad
Cr-Commit-Position: refs/heads/master@{#343700}

Powered by Google App Engine
This is Rietveld 408576698